Skip to content

Bugs/httpclient v2 #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 2, 2025
Merged

Bugs/httpclient v2 #491

merged 4 commits into from
Apr 2, 2025

Conversation

sophie-sudoku
Copy link
Collaborator

Update the last remaining webclient fragments to httpclient. i do not know how to test the functions downloadConverter() in PRo3D.Viewer\Viewer\SceneConverter.fs and module Net in PRo3D.Viewer\Utilities.fs - these code updates are untested

@haraldsteinlechner haraldsteinlechner changed the base branch from main to develop March 11, 2025 11:13
let fromDate (dt : DateTime) =
dt.ToString("yyyymmdd_hhmmss")

let takeScreenshot baseAddress (width:int) (height:int) name folder =
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was unused, right?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haraldsteinlechner haraldsteinlechner merged commit edb43a9 into develop Apr 2, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants