Skip to content

Prettify MD/YAML files #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kianmeng
Copy link

Resolved via prettier -w .

Attention: @prkumar

Resolved via `prettier -w .`
@codecov
Copy link

codecov bot commented Aug 27, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (65125ec) to head (8324af2).
Report is 65 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #275   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           44        44           
  Lines         2471      2471           
  Branches       358       358           
=========================================
  Hits          2471      2471           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kianmeng
Copy link
Author

🥳 🥳 🥳 🥳 🥳

Copy link

@EvaSDK EvaSDK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving the PR because it is good to apply formatting tool to avoid inconsistencies but I think it would be even better to leverage pre-commit and either use prettier hook or add yamlfmt/yamllint and mdformat hooks so these changes can be done while developing. It should also be integrated in Travis so it is checked even if someone forgot to install pre-commit locally. Anyway, these comments are material for another PR.

@leiserfg
Copy link
Collaborator

I think it's better to add this as a hook in pre-commit.

@kianmeng
Copy link
Author

kianmeng commented Apr 7, 2025

@prkumar Should I resolve the conflict and resubmit the PR again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants