Clarify where graphcool add-template needs to be run from #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was not obvious that the command `graphcool add-template` should be run from within the server directory. Hopefully this helps to clarify things.
kbrandwijk
suggested changes
Nov 4, 2017
auth/auth0/README.md
Outdated
| @@ -6,6 +6,7 @@ Add Auth0 Authentication to your Graphcool project 🎁 | |||
| ## Getting Started | |||
|
|
|||
| ### 1. Add the template to your Graphcool service | |||
| From your server directory (e.g. if you were to just have run `graphcool init server` your "server directory" would be `./server`) run: | |||
There was a problem hiding this comment.
I would say 'service directory', as the standard terminology is 'Graphcool service'.
This is to incorporate feedback around the common terminology for graphcool
|
@kbrandwijk updated wording per your suggestion |
kbrandwijk
suggested changes
Nov 10, 2017
auth/auth0/README.md
Outdated
| @@ -6,7 +6,7 @@ Add Auth0 Authentication to your Graphcool project 🎁 | |||
| ## Getting Started | |||
|
|
|||
| ### 1. Add the template to your Graphcool service | |||
| From your server directory (e.g. if you were to just have run `graphcool init server` your "server directory" would be `./server`) run: | |||
| From your server directory (e.g. if you were to just have run `graphcool init server` your "service directory" would be `./server`) run: | |||
There was a problem hiding this comment.
Also: 'From your service directory'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was not obvious that the command
graphcool add-templateshould be run from within the server directory. Hopefully this helps to clarify things.