You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sticking to Capybara's API for getting document text should (in theory) make this less likely to break in the event of a browser changing how it renders plain text/JSON responses.
Arguably, it also reads slightly better.
Screenshots
There should be no visual changes.
Integration
List the issues that this change affects.
Risk Assessment
Low risk the change is small, highly observable, and easily rolled back.
Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.
What approach did you choose and why?
Anything you want to highlight for special attention from reviewers?
Accessibility
Fixes axe scan violation - This change fixes an existing axe scan violation.
No new axe scan violation - This change does not introduce any new axe scan violations.
New axe violation - This change introduces a new axe scan violation. Please describe why the violation cannot be resolved below.
Merge checklist
Added/updated tests
Added/updated documentation
Added/updated previews (Lookbook)
Tested in Chrome
Tested in Firefox
Tested in Safari
Tested in Edge
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Hey @myabc, thanks for working on this, and apologies I missed it! It looks like system tests are failing in Firefox for some reason, would you be able to look into that? No need to add a changeset 😄
@TylerJDev Sorry for the delay in following up. I finally got a chance to look at the failing test. The issue was with waiting: while calling find("pre") waits, calling page.document.text does not. This was resolved in a driver-agnostic way by calling assert_current_path before asserting JSON values.
Adds `assert_json_response` and `json_response` helper method.
Sticking to Capybara's API for getting document text should (in theory)
make this less likely to break in the event of a browser changing how it
renders plain text/JSON responses.
Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.
skip changesetPull requests that don't change the library outputStaleAutomatically marked as stale.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
myabc
force-pushed
the
feature/test-json-response-improvements
branch
from
camertron
added
the
skip changeset
What are you trying to accomplish?
Sticking to Capybara's API for getting document text should (in theory) make this less likely to break in the event of a browser changing how it renders plain text/JSON responses.
Arguably, it also reads slightly better.
Screenshots
There should be no visual changes.
Integration
List the issues that this change affects.
Risk Assessment
What approach did you choose and why?
Anything you want to highlight for special attention from reviewers?
Accessibility
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.