Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix replacement URL for React getting started #4571

Merged
merged 1 commit into from May 16, 2024
Merged

Conversation

MrChrisW
Copy link
Member

@MrChrisW MrChrisW commented May 8, 2024

Changed

The existing link shown with the deprecation banner on https://primer.style/react/getting-started points to https://primer.style/design/guides/development/react which is incorrect and results in a 404 not found.

This updates the replacement URL to the correct value of https://primer.style/guides/react

Rollout strategy

  • None; if selected, include a brief description as to why

Merge checklist

  • Added/updated documentation

@MrChrisW MrChrisW self-assigned this May 8, 2024
@MrChrisW MrChrisW requested a review from a team as a code owner May 8, 2024 04:35
@MrChrisW MrChrisW requested a review from keithamus May 8, 2024 04:35
Copy link

changeset-bot bot commented May 8, 2024

⚠️ No Changeset found

Latest commit: 9368af2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented May 8, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 88.24 KB (0%)
packages/react/dist/browser.umd.js 88.68 KB (0%)

Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@joshblack joshblack added the skip changeset This change does not need a changelog label May 16, 2024
@joshblack joshblack added this pull request to the merge queue May 16, 2024
Merged via the queue into main with commit 2d26f4c May 16, 2024
33 of 34 checks passed
@joshblack joshblack deleted the fix-url-react branch May 16, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants