ActionList: Fix leaky disabled description styles #4566
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Description in a disabled item should not have
color: fg.muted
but the disabled color. We set this by adding the disabled color on the item and addingcolor:inherit
on the description. SourceThis feels safe because we are only targeting
Description
insideli[aria-disabled=true]
. This is the generated css:The trouble here is that the generated className for '&' is not the className just for
ActionList.Description
but is passed to multiple elements withinActionList.Item
. 馃This really threw me off!
Solution
As a quick fix, I added a
data-component
to make the selector more specific. Expecting no visual changes, only changes in the generated css.Rollout strategy
Testing & Reviewing
Merge checklist