Trigger onClose when Dialog backdrop is clicked #4565
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to https://github.com/github/primer/issues/2531
Relates to https://github.com/github/repos/issues/9248
Alternative to https://github.com/github/primer/issues/1838
I'd like to allow the v2 Dialog to be closed by clicking on the backdrop overlay. This is currently not supported, though the v1 Dialog and PVC dialog support this behavior.
Based on the usage guidelines, there are some unique cases where clicking the backdrop should not close the dialog. By passing in a new
backdrop
gesture, there is an escape hatch for these unique cases to ignorebackdrop
events on a case-by-case basis.Changelog
New
Dialog and ConfirmationDialog can now be closed by clicking on the backdrop round the dialog. This will cause
onClose
to be called with a new'backdrop'
gesture.Changed
Removed
Rollout strategy
Testing & Reviewing
Merge checklist