Skip to content

Add @primeuix/styles dependency to @primevue/core #7761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jnoordsij
Copy link

@jnoordsij jnoordsij commented May 26, 2025

In 9ac4c5a a practical dependency for @primevue/core on @primeuix/styles was introduced, which was never added as an actual dependency in the (package.json) dependencies of the project.

When working with e.g. npm, this works just fine as hoisting will solve this issue. However stricter package managers, e.g. Yarn with PnP mode, will fail when trying to build code with the following message:

[vite]: Rollup failed to resolve import "@primeuix/styles/base" from ".../.cache/yarn/@primevue-core-npm-4.3.4-c09e12b8ba-fad8d40ff8.zip/node_modules/@primevue/core/base/style/index.mjs".
This is most likely unintended because it can break your application at runtime.

This PR aims to resolve this issue by formally adding the corresponding dependency.

As a (temporary) workaround one can manually patch dependencies for yarn by adding the following to your .yarnrc.yml file:

packageExtensions:
  "@primevue/core@*":
    dependencies:
      "@primeuix/styles": "^1.1.1"

@mertsincan mertsincan self-assigned this May 26, 2025
@mertsincan mertsincan added the Status: Pending Review Issue or pull request is being reviewed by Core Team label May 26, 2025
@mertsincan mertsincan added this to the 4.3.5 milestone May 26, 2025
@github-project-automation github-project-automation bot moved this to Review in PrimeVue May 26, 2025
@tugcekucukoglu tugcekucukoglu modified the milestones: 4.3.5, 4.3.6 Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
Status: Review
Development

Successfully merging this pull request may close these issues.

3 participants