fix: onChange Text setProp many times #731
Open
+15
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
onChange
function inContentEditable
ofexample/landing/components/selectors/Text
is triggered every timeText
is clicked, causingsetProp
to be called and changingcanUndo
andcanRedo
. Add aref
to check the value ofText
and only callsetProp
when it changes. Decodee.target.value
usingdecodeHTML
to ensure the data is compared accurately.