Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: onChange Text setProp many times #731

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

phamvanhieu3012
Copy link

The onChange function in ContentEditable of example/landing/components/selectors/Text is triggered every time Text is clicked, causing setProp to be called and changing canUndo and canRedo. Add a ref to check the value of Text and only call setProp when it changes. Decode e.target.value using decodeHTML to ensure the data is compared accurately.

Copy link

changeset-bot bot commented Mar 3, 2025

⚠️ No Changeset found

Latest commit: d08a58a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
craftjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 3, 2025 9:23am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant