New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test framework specific warnings #193
base: main
Are you sure you want to change the base?
Conversation
I created this from the add-framework-option branch, I didn't noticed that you've merged that branch until I pushed this. |
Yeah it was in this moment ^^ I think you can use |
@SkyaTura Or maybe if this doesn't work well, you need |
Merge main into the branch works just fine to "fix" it. Although it keeps a lot a commits 馃槀 |
Yeah with the But for testing the logs we should consider using mocks or spys (https://stackoverflow.com/questions/49096093/how-do-i-test-a-jest-console-log) instead of adding runtime code to the project 馃 |
258d62b
to
56544e3
Compare
So I now used |
@SkyaTura I'm looking forward to release a v1.14.0 bundling this feature, the new docs and hopefully also now issue-167 if |
I can work on it in this weekend, for sure. |
Hey @Shinigami92 . 馃憢馃徎 I successfully managed to use Also, I need someone that actually works with Angular to tell me test cases that throws those warnings, because I wasn't able to reproduce it. |
Don't fear the linting warnings and errors 馃槃 You may look into some older issues like these: https://github.com/prettier/plugin-pug/issues?q=is%3Aissue+label%3A%22framework%3A+Angular%22 |
I managed to add one test case, unfortunately I didn't found examples to the other warnings 馃槥 |
Hey, think positive 馃槂 I think most of the messages where catched due to reports from using But I could be false remembering here I think I will also look into some messages again the next few days and find out how to throw them forcefully in tests |
WOW! @SkyaTura I found out that most tests are falling falsely into the default case 馃槙 But I will do that later, give me some days |
Hey @Shinigami92 , I found a (kind of) easy way to test framework warnings. Could you please have a look on this?
By the way, I'm not a TypeScripter myself, so there is some lint errors that I don't know how to fix.
Also, I don't know how to trigger Angular's specific warnings 馃槀