feat(Prestissimo): Make Broadcast writes directories configurable

[mkarrmann]

Summary:
Adds support for configuring the directory used for Storage-based Broadcasts in Velox.

The "config" is a transparent string, which is expected to be interpreted by the Filesystem.

Differential Revision: D87552571

[sourcery-ai]

Reviewer's Guide

Introduces a new configuration property to customize directory creation for Storage-based Broadcasts in Velox by passing a user-defined string to the filesystem’s mkdir operation.

Sequence diagram for BroadcastWriteOperator directory creation with configurable options

sequenceDiagram
participant "BroadcastWriteOperator"
participant "SystemConfig"
participant "FileSystem"

"BroadcastWriteOperator"->>"SystemConfig": broadcasterDirectoryCreateConfig()
"SystemConfig"-->>"BroadcastWriteOperator": config string
"BroadcastWriteOperator"->>"FileSystem": mkdir(basePath, dirOptions)
"FileSystem"-->>"BroadcastWriteOperator": Directory created

Loading

Class diagram for updated SystemConfig with broadcaster directory config

classDiagram
class SystemConfig {
  +std::string spillerDirectoryCreateConfig() const
  +std::string broadcasterDirectoryCreateConfig() const
  +folly::Optional<std::string> spillerSpillPath() const
  +int32_t shutdownOnsetSec() const
  static constexpr std::string_view kBroadcasterDirectoryCreateConfig
}

Loading

File-Level Changes

Change	Details	Files
Integrate broadcasterDirectoryCreateConfig into BroadcastWriteOperator	Include SystemConfig header Retrieve broadcasterDirectoryCreateConfig from SystemConfig Populate DirectoryOptions with the config value if provided Invoke fileSystem->mkdir with DirectoryOptions	presto-native-execution/presto_cpp/main/operators/BroadcastWrite.cpp
Declare new broadcaster.directory-create-config in SystemConfig interface	Add kBroadcasterDirectoryCreateConfig constant Declare broadcasterDirectoryCreateConfig() accessor	presto-native-execution/presto_cpp/main/common/Configs.h
Implement broadcasterDirectoryCreateConfig registration and accessor	Register STR_PROP for kBroadcasterDirectoryCreateConfig in constructor Define broadcasterDirectoryCreateConfig() to return the property value	presto-native-execution/presto_cpp/main/common/Configs.cpp

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes - here's some feedback:

• Consider refactoring the logic that reads the directory create config and builds DirectoryOptions into a shared helper (it’s almost identical in the spiller code) to avoid duplication.
• It might be worth adding error handling or logging around the filesystem mkdir call so that failures due to an invalid directoryCreateConfig are surfaced with context.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Consider refactoring the logic that reads the directory create config and builds DirectoryOptions into a shared helper (it’s almost identical in the spiller code) to avoid duplication.
- It might be worth adding error handling or logging around the filesystem mkdir call so that failures due to an invalid directoryCreateConfig are surfaced with context.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[mkarrmann]

Closing. We have a better solution for our internal use case, and it's unclear if anyone else would benefit from this.