fix(plugin-pinot): Normalize mixed-case Pinot table/column name handling when case-sensitive flag is disabled

[sh-shamsan]

Description

Motivation and Context

Impact

Test Plan

Contributor checklist

• Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
• PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
• Documented new properties (with its default value), SQL syntax, functions, or other functionality.
• If release notes are required, they follow the release notes guidelines.
• Adequate tests were added if applicable.
• CI passed.
• If adding new dependencies, verified they have an OpenSSF Scorecard score of 5.0 or higher (or obtained explicit TSC approval for lower scores).

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* ... 

[sourcery-ai]

Reviewer's Guide

Introduce identifier normalization for mixed-case table and column names when case sensitivity is disabled by propagating session context to metadata lookups and adding a case-sensitivity flag to column mapping.

Sequence diagram for normalized table name lookup in PinotMetadata

sequenceDiagram
    participant S as "ConnectorSession"
    participant M as "PinotMetadata"
    participant C as "PinotConnection"
    S->>M: getTableHandle(session, tableName)
    M->>M: getPinotTableNameFromPrestoTableName(session, tableName.getTableName())
    M->>C: getTableNames()
    M->>M: normalizeIdentifier(session, prestoTableName)
    M->>M: normalizeIdentifier(session, pinotTableName)
    M->>M: Compare normalized names
    M-->>S: PinotTableHandle

Loading

Sequence diagram for PinotColumn creation with case sensitivity flag

sequenceDiagram
    participant PC as "PinotConnection"
    participant CU as "PinotColumnUtils"
    participant Col as "PinotColumn"
    PC->>CU: getPinotColumnsForPinotSchema(schema, ..., nullHandlingEnabled, isCaseSensitiveNameMatchingEnabled)
    CU->>CU: For each columnName in schema
    CU->>Col: PinotColumn(name, ...)
    Note right of Col: name is normalized to lower-case if flag is false
    CU-->>PC: List<PinotColumn>

Loading

Class diagram for updated PinotMetadata and PinotColumnUtils normalization logic

classDiagram
    class PinotMetadata {
        - pinotPrestoConnection: PinotConnection
        + listSchemaNames(session)
        - getPinotTableNameFromPrestoTableName(session, prestoTableName)
        + getTableHandle(session, tableName)
        + getTableMetadata(session, tableName)
        + getColumnHandles(session, tableHandle)
        + listTableColumns(session, prefix)
    }
    class PinotColumnUtils {
        + getPinotColumnsForPinotSchema(pinotTableSchema, inferDateType, inferTimestampType)
        + getPinotColumnsForPinotSchema(pinotTableSchema, inferDateType, inferTimestampType, nullHandlingEnabled, isCaseSensitiveNameMatchingEnabled)
    }
    PinotMetadata --> PinotColumnUtils : uses
    PinotMetadata --> PinotConnection : uses
    PinotConnection --> PinotColumnUtils : uses

Loading

Class diagram for PinotColumn creation with case sensitivity flag

classDiagram
    class PinotColumn {
        + PinotColumn(name, type, nullable, comment)
        - name: String
        - type: PrestoType
        - nullable: boolean
        - comment: String
    }
    PinotColumnUtils --> PinotColumn : creates
    PinotColumnUtils : +getPinotColumnsForPinotSchema(..., isCaseSensitiveNameMatchingEnabled)
    PinotColumn : name is normalized to lower-case if isCaseSensitiveNameMatchingEnabled is false

Loading

File-Level Changes

Change	Details	Files
Propagate session to table name resolution and normalize identifiers	Added ConnectorSession parameter to methods resolving Pinot table names Used normalizeIdentifier(session, name) for both Presto and Pinot names Updated calls to include session in getTableMetadata, getColumnHandles, and listTableColumns	PinotMetadata.java
Add case-sensitivity flag to column name mapping	Extended getPinotColumnsForPinotSchema signature with isCaseSensitiveNameMatchingEnabled Conditionally lowercase columnName when case sensitivity is disabled Updated default overload to pass false for the new flag	PinotColumnUtils.java
Pass case-sensitivity config through connection layer	Updated PinotConnection.load to forward pinotConfig.isCaseSensitiveNameMatchingEnabled() Adjusted call site to new getPinotColumnsForPinotSchema signature	PinotConnection.java

Possibly linked issues

• #N/A: The PR normalizes mixed-case column names to lowercase when case-insensitive matching is enabled, resolving the UPDATE statement failures with uppercase column names.
• #issue: The PR normalizes Pinot column names to lowercase, fixing the inconsistent identifier normalization that caused UPDATE SET failures with mixed-case column names in the issue.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.