Skip to content

Conversation

@feilong-liu
Copy link
Contributor

Description

cast function is special as it needs to specify both input and output types, hence cannot use the existing lookupBuiltInFunction API. Add the lookupCast API in this PR

Motivation and Context

See description

Impact

See description

Test Plan

Unit test

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.
  • If adding new dependencies, verified they have an OpenSSF Scorecard score of 5.0 or higher (or obtained explicit TSC approval for lower scores).

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==

@prestodb-ci prestodb-ci added the from:Meta PR from Meta label Nov 19, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 19, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR adds a dedicated lookupCast API to the SQL function resolution layer, enabling explicit resolution of cast functions by input and output types, and updates unit tests to verify its behavior.

Class diagram for updated StandardFunctionResolution interface and FunctionResolution implementation

classDiagram
class StandardFunctionResolution {
  +boolean isCastFunction(FunctionHandle functionHandle)
  +FunctionHandle lookupCast(String castType, Type fromType, Type toType)
  +boolean isCountFunction(FunctionHandle functionHandle)
  +boolean isCountIfFunction(FunctionHandle functionHandle)
}
class FunctionResolution {
  +boolean isCastFunction(FunctionHandle functionHandle)
  +FunctionHandle lookupCast(String castType, Type fromType, Type toType)
  +boolean isTryCastFunction(FunctionHandle functionHandle)
}
StandardFunctionResolution <|.. FunctionResolution
FunctionResolution --> functionAndTypeResolver: uses
functionAndTypeResolver : lookupCast(castType, fromType, toType)
functionAndTypeResolver : getFunctionMetadata(functionHandle)
Loading

File-Level Changes

Change Details Files
Add lookupCast API to resolve cast functions requiring explicit input and output types
  • Declare lookupCast in StandardFunctionResolution interface
  • Implement lookupCast delegation to functionAndTypeResolver in FunctionResolution
  • Maintain existing lookupBuiltInFunction behavior for non-cast functions
presto-spi/src/main/java/com/facebook/presto/spi/function/StandardFunctionResolution.java
presto-main-base/src/main/java/com/facebook/presto/sql/relational/FunctionResolution.java
Extend unit tests to cover lookupCast and isCastFunction
  • Add assertion that lookupCast returns a valid cast FunctionHandle
  • Verify isCastFunction recognizes the returned handle
presto-main-base/src/test/java/com/facebook/presto/sql/relational/TestFunctionResolution.java

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • The new SPI method lookupCast should either have a default implementation or be added to all existing implementations to avoid breaking backwards compatibility.
  • Rather than passing a raw string for the cast function name, consider using a QualifiedObjectName or enum to enforce type safety and prevent typos in the lookupCast API.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The new SPI method lookupCast should either have a default implementation or be added to all existing implementations to avoid breaking backwards compatibility.
- Rather than passing a raw string for the cast function name, consider using a QualifiedObjectName or enum to enforce type safety and prevent typos in the lookupCast API.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@feilong-liu feilong-liu changed the title mis: Add lookup cast in standard function resolution misc: Add lookup cast in standard function resolution Nov 20, 2025
@feilong-liu feilong-liu requested a review from kaikalur November 20, 2025 00:57
Copy link
Member

@hantangwangd hantangwangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@feilong-liu feilong-liu merged commit 02d78e8 into prestodb:master Nov 20, 2025
82 of 83 checks passed
@feilong-liu feilong-liu deleted the lookup_cast branch November 20, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:Meta PR from Meta

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants