Skip to content

feat: Add JSON to WriterTarget #26471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: Add JSON to WriterTarget #26471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions presto-main-base/src/main/java/com/facebook/presto/sql/planner/CanonicalPlan.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
*/
package com.facebook.presto.sql.planner;

import com.facebook.airlift.log.Logger;
import com.facebook.presto.common.plan.PlanCanonicalizationStrategy;
import com.facebook.presto.spi.PrestoException;
import com.facebook.presto.spi.plan.PlanNode;
Expand All @@ -29,6 +30,7 @@

public class CanonicalPlan
{
private static final Logger log = Logger.get(CanonicalPlan.class);
Copy link
Contributor

@feilong-liu feilong-liu Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logger is not used?

Copy link
Contributor Author

@tanjialiang tanjialiang Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will remove

private final PlanNode plan;
private final PlanCanonicalizationStrategy strategy;

Expand Down
5 changes: 4 additions & 1 deletion presto-main-base/src/main/java/com/facebook/presto/sql/planner/CanonicalPlanGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@
import com.facebook.presto.sql.planner.plan.SequenceNode;
import com.facebook.presto.sql.planner.plan.TopNRowNumberNode;
import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonIgnore;
import com.fasterxml.jackson.annotation.JsonProperty;
import com.fasterxml.jackson.core.JsonProcessingException;
import com.fasterxml.jackson.databind.ObjectMapper;
Expand Down Expand Up @@ -1081,7 +1082,7 @@ private Optional<List<Integer>> orderSourcesByTables(List<PlanNode> sources)
return Optional.of(sourceToPosition.values().stream().collect(toImmutableList()));
}

private static class CanonicalWriterTarget
public static class CanonicalWriterTarget
extends TableWriterNode.WriterTarget
{
private final ConnectorId connectorId;
Expand Down Expand Up @@ -1110,13 +1111,15 @@ public String getWriterTargetType()
}

@Override
@JsonIgnore
public SchemaTableName getSchemaTableName()
{
// Just return a sample table name, which is always same
return new SchemaTableName("schema", "table");
}

@Override
@JsonIgnore
public Optional<List<OutputColumnMetadata>> getOutputColumns()
{
return Optional.empty();
Expand Down
10 changes: 8 additions & 2 deletions presto-spi/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,13 +102,13 @@
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
<scope>test</scope>
<scope>provided</scope>
</dependency>

<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-core</artifactId>
<scope>test</scope>
<scope>provided</scope>
</dependency>

<dependency>
Expand Down Expand Up @@ -146,5 +146,11 @@
<artifactId>commons-math3</artifactId>
<scope>test</scope>
</dependency>

<dependency>
<groupId>javax.inject</groupId>
<artifactId>javax.inject</artifactId>
<scope>test</scope>
</dependency>
</dependencies>
</project>
1 change: 1 addition & 0 deletions presto-spi/src/main/java/com/facebook/presto/spi/ColumnMetadata.java
View file
Open in desktop
Copy link
Contributor

@aditi-pandit aditi-pandit Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this diff ?

Copy link
Contributor Author

@tanjialiang tanjialiang Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the empty line when coming across this file seeing the lacking of the empty line. But if we don't want it in this PR I can remove.

Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ public Map<String, Object> getProperties()
{
return properties;
}

public Builder toBuilder()
{
return ColumnMetadata.builder()
Expand Down
Loading
Loading