Skip to content

fix: Add P4HyperLogLog to NativeTypeManager #26444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2025
Merged

fix: Add P4HyperLogLog to NativeTypeManager #26444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...decar-plugin/src/main/java/com/facebook/presto/sidecar/typemanager/NativeTypeManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
import static com.facebook.presto.common.type.StandardTypes.IPPREFIX;
import static com.facebook.presto.common.type.StandardTypes.JSON;
import static com.facebook.presto.common.type.StandardTypes.MAP;
import static com.facebook.presto.common.type.StandardTypes.P4_HYPER_LOG_LOG;
import static com.facebook.presto.common.type.StandardTypes.QDIGEST;
import static com.facebook.presto.common.type.StandardTypes.REAL;
import static com.facebook.presto.common.type.StandardTypes.ROW;
Expand Down Expand Up @@ -90,6 +91,7 @@ public class NativeTypeManager
DOUBLE,
SMALLINT,
HYPER_LOG_LOG,
P4_HYPER_LOG_LOG,
JSON,
TIMESTAMP_WITH_TIME_ZONE,
UUID,
Expand Down
24 changes: 24 additions & 0 deletions ...ive-sidecar-plugin/src/test/java/com/facebook/presto/sidecar/TestNativeSidecarPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

import com.facebook.airlift.units.DataSize;
import com.facebook.presto.Session;
import com.facebook.presto.common.type.Type;
import com.facebook.presto.nativeworker.PrestoNativeQueryRunnerUtils;
import com.facebook.presto.scalar.sql.NativeSqlInvokedFunctionsPlugin;
import com.facebook.presto.scalar.sql.SqlInvokedFunctionsPlugin;
Expand Down Expand Up @@ -42,6 +43,7 @@
import org.testng.annotations.Test;

import java.util.List;
import java.util.Map;
import java.util.UUID;
import java.util.regex.Pattern;
import java.util.stream.Collectors;
Expand All @@ -52,12 +54,15 @@
import static com.facebook.presto.SystemSessionProperties.REMOVE_MAP_CAST;
import static com.facebook.presto.common.Utils.checkArgument;
import static com.facebook.presto.common.type.BigintType.BIGINT;
import static com.facebook.presto.common.type.DoubleType.DOUBLE;
import static com.facebook.presto.common.type.VarcharType.VARCHAR;
import static com.facebook.presto.nativeworker.NativeQueryRunnerUtils.createCustomer;
import static com.facebook.presto.nativeworker.NativeQueryRunnerUtils.createLineitem;
import static com.facebook.presto.nativeworker.NativeQueryRunnerUtils.createNation;
import static com.facebook.presto.nativeworker.NativeQueryRunnerUtils.createOrders;
import static com.facebook.presto.nativeworker.NativeQueryRunnerUtils.createOrdersEx;
import static com.facebook.presto.nativeworker.NativeQueryRunnerUtils.createRegion;
import static com.facebook.presto.testing.MaterializedResult.resultBuilder;
import static java.lang.String.format;
import static org.testng.Assert.assertEquals;
import static org.testng.Assert.assertFalse;
Expand Down Expand Up @@ -622,6 +627,25 @@ public void testNonOverriddenInlinedSqlInvokedFunctionsWhenConfigDisabled()
".*Scalar function name not registered: native.default.key_sampling_percent.*");
}

@Test
public void testP4HyperLogLogWithApproxSet()
{
// Map each SQL type to its expected NDV.
Map<Type, Long> typeToNdvMap = ImmutableMap.of(
BIGINT, 1002L,
VARCHAR, 1024L,
DOUBLE, 1014L);
for (Map.Entry<Type, Long> entry : typeToNdvMap.entrySet()) {
Type type = entry.getKey();
Long expectedNdv = entry.getValue();
MaterializedResult actual = computeActual(String.format("SELECT cardinality(cast(approx_set(cast(custkey AS %s)) AS P4HYPERLOGLOG)) FROM orders", type.getTypeSignature().toString()));
MaterializedResult expectedResult = resultBuilder(getSession(), BIGINT)
.row(expectedNdv)
.build();
assertEquals(actual.getMaterializedRows(), expectedResult.getMaterializedRows());
}
}

private String generateRandomTableName()
{
String tableName = "tmp_presto_" + UUID.randomUUID().toString().replace("-", "");
Expand Down
Loading