Skip to content

fix(native): Generation of thrift protocol #26419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2025
Merged

fix(native): Generation of thrift protocol #26419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion presto-native-execution/presto_cpp/main/thrift/thrift2json.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,9 @@ def preprocess(file_path, output_temp_path):
lines = file.readlines()
modified_lines = []
for line in lines:
modified_line = re.sub(r"\s*,*\s*drift\.recursive_reference=true\s*", "", line)
modified_line = re.sub(
r"\s*,*\s*drift\.recursive_reference\s*=\s*true\s*,*\s*", "", line
)
modified_line = re.sub(r"\(\s*\)$", "", modified_line)
modified_lines.append(modified_line)
with open(output_temp_path, "w") as file:
Expand Down
2 changes: 1 addition & 1 deletion presto-native-execution/scripts/setup-centos.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export NPROC=${NPROC:-$(getconf _NPROCESSORS_ONLN)}
function install_presto_deps_from_package_managers {
dnf install -y maven java clang-tools-extra jq perl-XML-XPath
# This python version is installed by the Velox setup scripts
pip install regex pyyaml chevron black
pip install regex pyyaml chevron black ptsd-jbroll
}

function install_gperf {
Expand Down
Loading