WIP feat(flight-shim): Adding Apache Arrow FlightShim for federation in C++ workers

[BryanCutler]

Description

This adds a FlightShim project with an Apache Arrow Flight server that is able to load Presto Java JDBC-based connectors and process JDBC splits and return a stream of Arrow record batches. See related RFC prestodb/rfcs#46

Motivation and Context

Impact

Test Plan

Contributor checklist

• Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
• PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
• Documented new properties (with its default value), SQL syntax, functions, or other functionality.
• If release notes are required, they follow the release notes guidelines.
• Adequate tests were added if applicable.
• CI passed.
• If adding new dependencies, verified they have an OpenSSF Scorecard score of 5.0 or higher (or obtained explicit TSC approval for lower scores).

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* ... 
* ... 

Hive Connector Changes
* ... 
* ... 

If release note is NOT required, use:

== NO RELEASE NOTE ==

[sourcery-ai]

Reviewer's Guide

This PR introduces a new "presto-flight-shim" Maven module that embeds an Apache Arrow Flight server into Presto workers, enabling federation over JDBC connectors. It implements a plugin manager to load and configure Presto JDBC-based connectors at runtime, a Flight producer to handle Flight gRPC calls and serialize/deserialize FlightShimRequests, and an ArrowBatchSource to stream JDBC splits as Arrow record batches. The module bootstraps via Guice, exposes configuration and JMX metrics, and is covered by end-to-end and unit tests across multiple connectors.

Sequence diagram for FlightShim FlightServer GetStream request handling

sequenceDiagram
  participant Client as "Flight Client"
  participant Server as "FlightServer (FlightShimServer)"
  participant Producer as "FlightShimProducer"
  participant PluginMgr as "FlightShimPluginManager"
  participant Connector as "JDBC Connector"
  participant ArrowBatch as "ArrowBatchSource"
  Client->>Server: Send GetStream request (Ticket)
  Server->>Producer: Delegate getStream(ticket)
  Producer->>PluginMgr: getConnector(connectorId)
  PluginMgr->>Connector: Load connector
  Producer->>Connector: getRecordSetProvider()
  Producer->>Connector: getRecordSet(split, columns)
  Producer->>ArrowBatch: Create ArrowBatchSource(recordSet)
  loop For each batch
    ArrowBatch->>Producer: nextBatch()
    Producer->>Client: Send Arrow record batch
  end
  Producer->>Client: completed()

Loading

Class diagram for new FlightShim core classes

classDiagram
  class FlightShimPluginManager {
    +loadPlugins()
    +loadCatalogs()
    +getConnector(String): ConnectorHolder
    -connectorFactories: Map
    -connectors: Map
    -catalogPropertiesMap: Map
    +stop()
  }
  class FlightShimPluginManager~ConnectorHolder~ {
    +getConnector(): Connector
    +getCodecSplit(): JsonCodec
    +getCodecColumnHandle(): JsonCodec
    +getColumnMetadata(ColumnHandle): ColumnMetadata
  }
  class FlightShimProducer {
    +getStream(CallContext, Ticket, ServerStreamListener)
    +close()
    -pluginManager: FlightShimPluginManager
    -allocator: BufferAllocator
    -config: FlightShimConfig
    -shimExecutor: ExecutorService
  }
  class ArrowBatchSource {
    +nextBatch(): boolean
    +getVectorSchemaRoot(): VectorSchemaRoot
    +close()
    -columns: List
    -cursor: RecordCursor
    -root: VectorSchemaRoot
    -writers: List
    -maxRowsPerBatch: int
  }
  class FlightShimConfig {
    +getServerName(): String
    +getServerPort(): Integer
    +getServerSslEnabled(): boolean
    +getMaxRowsPerBatch(): int
    +getReadSplitThreadPoolSize(): int
  }
  class FlightShimRequest {
    +getConnectorId(): String
    +getSplitBytes(): byte[]
    +getColumnHandlesBytes(): List<byte[]>
  }
  FlightShimPluginManager "1" o-- "*" FlightShimPluginManager~ConnectorHolder~
  FlightShimProducer "1" --> "1" FlightShimPluginManager
  FlightShimProducer "1" --> "1" FlightShimConfig
  FlightShimProducer "1" --> "1" ArrowBatchSource
  ArrowBatchSource "1" --> "1" VectorSchemaRoot
  FlightShimProducer "1" --> "1" BufferAllocator
  FlightShimProducer "1" --> "1" ExecutorService
  FlightShimRequest "1" --> "1" FlightShimProducer
  FlightShimConfig "1" --> "1" FlightShimProducer

Loading

File-Level Changes

Change	Details	Files
Register and configure a new presto-flight-shim Maven module	Added module entry in parent POM Created presto-flight-shim/pom.xml with dependencies and build plugins	pom.xml presto-flight-shim/pom.xml
Conversion of RecordCursor to Arrow record batches	Implemented ArrowBatchSource with vector schema creation, allocation, and batching Built ArrowShimWriter hierarchy for all supported Arrow types	presto-flight-shim/src/main/java/com/facebook/presto/flightshim/ArrowBatchSource.java
Dynamic loading and management of JDBC connectors	Developed FlightShimPluginManager to discover, load, and register connector factories Managed catalog properties, connector instances, and classloader isolation	presto-flight-shim/src/main/java/com/facebook/presto/flightshim/FlightShimPluginManager.java
Flight producer implementation for gRPC Flight API	Added FlightShimProducer to handle getStream calls and backpressure Serialized and deserialized FlightShimRequest and managed streaming lifecycles	presto-flight-shim/src/main/java/com/facebook/presto/flightshim/FlightShimProducer.java
Server bootstrap and dependency injection setup	Created FlightShimServer to initialize and start FlightServer Defined FlightShimModule (Guice bindings) and FlightShimConfig Exposed thread pool metrics via FlightShimServerExecutionMBean and qualifier	presto-flight-shim/src/main/java/com/facebook/presto/flightshim/FlightShimServer.java presto-flight-shim/src/main/java/com/facebook/presto/flightshim/FlightShimModule.java presto-flight-shim/src/main/java/com/facebook/presto/flightshim/FlightShimConfig.java presto-flight-shim/src/main/java/com/facebook/presto/flightshim/FlightShimServerExecutionMBean.java presto-flight-shim/src/main/java/com/facebook/presto/flightshim/ForFlightShimServer.java
FlightShim request data model	Added FlightShimRequest with JSON annotations for ticket payload	presto-flight-shim/src/main/java/com/facebook/presto/flightshim/FlightShimRequest.java
Integration and unit tests for FlightShim	Built abstract test frameworks for connector queries Implemented connector-specific tests (PostgreSQL, MySQL, Oracle, SingleStore) Added tests for config mapping and request JSON round-trip	presto-flight-shim/src/test/java/com/facebook/presto/flightshim/AbstractTestFlightShimBase.java presto-flight-shim/src/test/java/com/facebook/presto/flightshim/AbstractTestFlightShimQueries.java presto-flight-shim/src/test/java/com/facebook/presto/flightshim/TestFlightShimProducer.java presto-flight-shim/src/test/java/com/facebook/presto/flightshim/TestFlightShimRequest.java presto-flight-shim/src/test/java/com/facebook/presto/flightshim/TestFlightShimConfig.java presto-flight-shim/src/test/java/com/facebook/presto/flightshim/TestFlightShimMySql.java presto-flight-shim/src/test/java/com/facebook/presto/flightshim/TestFlightShimOracle.java presto-flight-shim/src/test/java/com/facebook/presto/flightshim/TestFlightShimPostgres.java presto-flight-shim/src/test/java/com/facebook/presto/flightshim/TestFlightShimSingleStore.java
Configuration and logging setup	Added default log.properties Added default flightshim.properties	presto-flight-shim/etc/log.properties presto-flight-shim/etc/flightshim.properties

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

New security issues found

[sourcery-ai]

New security issues found

[sourcery-ai]

security (private-key): Identified a Private Key, which may compromise cryptographic security and sensitive data encryption.

Source: gitleaks

[sourcery-ai]

security (private-key): Identified a Private Key, which may compromise cryptographic security and sensitive data encryption.

Source: gitleaks