Skip to content

Conversation

@rebeccaSimmonds19
Copy link
Contributor

Fix #23967

Added file check-commit-message.yml to the workflows folder to allow for auto check of commits

Description

This has added a automated check for commit messages using this. This is done by adding a check-commit-message.yml file to the workflows directory

Motivation and Context

This will help reduce work on reviewers and help new contributors

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==

…23967

Fix prestodb#23967

Added file check-commit-message.yml to the workflows folder to allow for auto check of commits
@rebeccaSimmonds19 rebeccaSimmonds19 requested review from a team, czentgr and unidevel as code owners August 27, 2025 06:02
@tdcmeehan
Copy link
Contributor

@rebeccaSimmonds19 would it be possible to cross check this plugin against several recent PRs to understand if it's doing the right thing?

@czentgr
Copy link
Contributor

czentgr commented Aug 27, 2025

Did we have a discussion on this? For PrestoC++ changes we add [native] at the beginning. Would this fail (it says it wants capitalization)?

@tdcmeehan I would propose scheme similar to Velox for commit messages (specifically the abstract) which itself was inspired by Arrow. Such scheme would counter this particular check here. Perhaps we should discuss this or was it discussed?

@tdcmeehan
Copy link
Contributor

@czentgr yes, I previously brought this up here: https://github.com/orgs/prestodb/discussions/23834

I'm wondering if there is an equivalent plugin for convention commits

@rebeccaSimmonds19
Copy link
Contributor Author

@rebeccaSimmonds19 would it be possible to cross check this plugin against several recent PRs to understand if it's doing the right thing?

Sorry for the late reply. Would you know a way to run github actions against a a PR on the repository at all?

@tdcmeehan
Copy link
Contributor

@rebeccaSimmonds19 it might be best to hold off for now, as I think we need to get community consensus on what approach to take--conventional commits, or the opinionated commit message style. We have a TSC meeting tomorrow where I'll bring this up, I'll update here with the outcome.

@steveburnett
Copy link
Contributor

Does #26122 affect this PR?

@tdcmeehan
Copy link
Contributor

Yes, we are now moving to conventional commits. Thank you for the work on adding this @rebeccaSimmonds19

@tdcmeehan tdcmeehan closed this Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider using the opinionated-commit-message Github Action

4 participants