-
Notifications
You must be signed in to change notification settings - Fork 5.5k
[native] Add TextReader and TextWriter #25626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@YiChengLee03 : Thanks for these code changes. Please can you add some e2e tests for this PR. If Text is a valid Hive storage format, then it would be good to add this as a storage format in https://github.com/prestodb/presto/blob/master/presto-native-execution/src/test/java/com/facebook/presto/nativeworker/PrestoNativeQueryRunnerUtils.java#L92, so that we can easily flip Native tests to use text format (just like we can switch between DWRF and Parquet). |
Sure! Thanks for catching that! |
b7963b7 to
b168d30
Compare
|
@YiChengLee03 @zacw7 can we get this PR approved and merge?Thanks. |
|
@YiChengLee03 @zacw7 Are you still working on this PR? If not, I can help with it. |
Please feel free to take it over. I can also resubmit this change. |
Description
Register Reader and Writer
Motivation and Context
Add support for Textfile reader and writer
Impact
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.