feat: Add max-prefixes-count session property

[sh-shamsan]

Description

An internal cherry-pick to make MAX_PREFIXES_COUNT configurable via session properties and config.properties. This helps improve performance of SHOW QUERY

Motivation and Context

Impact

Test Plan

UTs

Contributor checklist

• Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
• PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
• Documented new properties (with its default value), SQL syntax, functions, or other functionality.
• If release notes are required, they follow the release notes guidelines.
• Adequate tests were added if applicable.
• CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* Add configuration property ``max-prefixes-count``

[steveburnett]

Please add documentation for the new configuration and session properties in this PR.
https://github.com/prestodb/presto/blob/master/presto-docs/src/main/sphinx/admin/properties.rst

https://github.com/prestodb/presto/blob/master/presto-docs/src/main/sphinx/admin/properties-session.rst

[sourcery-ai]

Reviewer's Guide

This PR refactors the hard-coded max prefixes limit into a configurable session and server property, wiring it through FeaturesConfig and SystemSessionProperties, and updating InformationSchemaMetadata to respect the dynamic limit when calculating table prefixes. Tests have been adapted and extended to validate the new configuration end-to-end.

Entity relationship diagram for session and config properties

erDiagram
    FEATURES_CONFIG {
        int maxPrefixesCount
    }
    SYSTEM_SESSION_PROPERTIES {
        string MAX_PREFIXES_COUNT
    }
    SESSION {
        int maxPrefixesCount
    }
    FEATURES_CONFIG ||--o| SYSTEM_SESSION_PROPERTIES : exposes
    SYSTEM_SESSION_PROPERTIES ||--o| SESSION : sets

Loading

Class diagram for configurable max prefixes count

classDiagram
    class FeaturesConfig {
        - int maxPrefixesCount
        + setMaxPrefixesCount(Integer): FeaturesConfig
        + getMaxPrefixesCount(): int
    }
    class SystemSessionProperties {
        + MAX_PREFIXES_COUNT: String
        + getMaxPrefixesCount(Session): int
    }
    class InformationSchemaMetadata {
        + getTableLayoutForConstraint(...): ConnectorTableLayoutResult
    }
    FeaturesConfig <.. SystemSessionProperties : uses
    SystemSessionProperties <.. InformationSchemaMetadata : uses

Loading

File-Level Changes

Change	Details	Files
Expose max-prefixes-count in the feature configuration	Introduce maxPrefixesCount field with default 100 Add @config setter and getter for max-prefixes-count Include validation with @min(1) annotation	presto-main-base/src/main/java/com/facebook/presto/sql/analyzer/FeaturesConfig.java
Register and expose the session property	Define MAX_PREFIXES_COUNT constant Register integerProperty in SystemSessionProperties constructor Add getMaxPrefixesCount(session) helper method	presto-main-base/src/main/java/com/facebook/presto/SystemSessionProperties.java
Apply dynamic prefix limit in InformationSchemaMetadata	Remove hard-coded MAX_PREFIXES_COUNT constant Fetch maxPrefixesCount from session via SystemSessionProperties Replace static checks with dynamic comparisons in getTableLayoutForConstraint	presto-main-base/src/main/java/com/facebook/presto/connector/informationSchema/InformationSchemaMetadata.java
Adapt and extend tests for the new property	Introduce TEST_CATALOG constant Update createNewSession to accept and set maxPrefixesCount Modify tests to use dynamic session property and constants Add default and explicit mapping assertions in TestFeaturesConfig	presto-main-base/src/test/java/com/facebook/presto/metadata/TestInformationSchemaMetadata.java presto-main-base/src/test/java/com/facebook/presto/sql/analyzer/TestFeaturesConfig.java

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

Prompt for AI Agents

Please address the comments from this code review:

## Individual Comments

### Comment 1
<location> `presto-main-base/src/test/java/com/facebook/presto/metadata/TestInformationSchemaMetadata.java:163` </location>
<code_context>
+                .setCatalog(TEST_CATALOG)
                 .setSchema("information_schema")
                 .setTransactionId(transactionId)
+                .setSystemProperty(MAX_PREFIXES_COUNT, String.valueOf(maxPrefixesCount))
                 .build()
                 .toConnectorSession();
</code_context>

<issue_to_address>
**suggestion (testing):** Missing test for boundary and invalid values of maxPrefixesCount session property.

Add tests for maxPrefixesCount at its minimum (1), a large value, and invalid values (0, negative) to verify correct handling and enforcement of the @Min(1) constraint.

Suggested implementation:

```java
    private ConnectorSession createNewSession(TransactionId transactionId, int maxPrefixesCount)
    {
        return testSessionBuilder()
                .setCatalog(TEST_CATALOG)
                .setSchema("information_schema")
                .setTransactionId(transactionId)
                .setSystemProperty(MAX_PREFIXES_COUNT, String.valueOf(maxPrefixesCount))
                .build()
                .toConnectorSession();
    }

    @Test
    public void testMaxPrefixesCountSessionPropertyBoundaries()
    {
        TransactionId transactionId = TransactionId.create();
        // Minimum valid value
        ConnectorSession sessionMin = createNewSession(transactionId, 1);
        assertEquals(Integer.parseInt(sessionMin.getSystemProperty(MAX_PREFIXES_COUNT)), 1);

        // Large valid value
        int largeValue = 1000000;
        ConnectorSession sessionLarge = createNewSession(transactionId, largeValue);
        assertEquals(Integer.parseInt(sessionLarge.getSystemProperty(MAX_PREFIXES_COUNT)), largeValue);

        // Invalid value: zero
        try {
            createNewSession(transactionId, 0);
            fail("Expected exception for maxPrefixesCount = 0");
        }
        catch (IllegalArgumentException | RuntimeException e) {
            // Expected
        }

        // Invalid value: negative
        try {
            createNewSession(transactionId, -5);
            fail("Expected exception for maxPrefixesCount = -5");
        }
        catch (IllegalArgumentException | RuntimeException e) {
            // Expected
        }
    }

```

If the session property validation does not currently throw an exception for invalid values, you may need to add or adjust validation logic elsewhere in the codebase to enforce the @Min(1) constraint.
</issue_to_address>

### Comment 2
<location> `presto-main-base/src/test/java/com/facebook/presto/sql/analyzer/TestFeaturesConfig.java:62` </location>
<code_context>
     public void testDefaults()
     {
         assertRecordedDefaults(ConfigAssertions.recordDefaults(FeaturesConfig.class)
+                .setMaxPrefixesCount(100)
                 .setCpuCostWeight(75)
                 .setMemoryCostWeight(10)
</code_context>

<issue_to_address>
**suggestion (testing):** Missing test for invalid max-prefixes-count property in FeaturesConfig.

Add a test to ensure that invalid max-prefixes-count values (such as 0 or negative) are properly rejected according to the @Min(1) constraint.
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[steveburnett]

Thanks for the documentation! A few requests.

[steveburnett]

LGTM! (docs)

Pull updated branch, new local doc build. Looks good, thanks for the updates!

[agrawalreetika]

LGTM

[prestodb-ci]

@czentgr imported this issue as lakehouse/presto #25550

[prestodb-ci]

@mohsaka imported this issue as lakehouse/presto #25550