Skip to content

Refactor AbstractTestQueries testcases for native-tests #25486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2025
Merged

Refactor AbstractTestQueries testcases for native-tests #25486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...o-accumulo/src/test/java/com/facebook/presto/accumulo/TestAccumuloDistributedQueries.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import com.google.common.collect.ImmutableList;
import com.google.common.collect.ImmutableMap;
import org.intellij.lang.annotations.Language;
import org.testng.annotations.Optional;
import org.testng.annotations.Test;

import static com.facebook.presto.accumulo.AccumuloQueryRunner.createAccumuloQueryRunner;
Expand Down Expand Up @@ -324,7 +325,7 @@ public void testScalarSubquery()
}

@Override
public void testShowColumns()
public void testShowColumns(@Optional("PARQUET") String storageFormat)
{
// Override base class because table descriptions for Accumulo connector include comments
MaterializedResult actual = computeActual("SHOW COLUMNS FROM orders");
Expand Down
3 changes: 2 additions & 1 deletion presto-cassandra/src/test/java/com/facebook/presto/cassandra/TestCassandraDistributed.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
import com.facebook.presto.testing.QueryRunner;
import com.facebook.presto.tests.AbstractTestDistributedQueries;
import org.testng.annotations.AfterClass;
import org.testng.annotations.Optional;

import static com.facebook.presto.common.type.VarcharType.VARCHAR;
import static com.facebook.presto.testing.MaterializedResult.resultBuilder;
Expand Down Expand Up @@ -114,7 +115,7 @@ public void testUpdate()
}

@Override
public void testShowColumns()
public void testShowColumns(@Optional("PARQUET") String storageFormat)
{
MaterializedResult actual = computeActual("SHOW COLUMNS FROM orders");

Expand Down
3 changes: 2 additions & 1 deletion presto-mysql/src/test/java/com/facebook/presto/plugin/mysql/TestMySqlDistributedQueries.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import io.airlift.tpch.TpchTable;
import io.airlift.units.Duration;
import org.testng.annotations.AfterClass;
import org.testng.annotations.Optional;
import org.testng.annotations.Test;

import java.io.IOException;
Expand Down Expand Up @@ -70,7 +71,7 @@ public final void destroy()
}

@Override
public void testShowColumns()
public void testShowColumns(@Optional("PARQUET") String storageFormat)
{
MaterializedResult actual = computeActual("SHOW COLUMNS FROM orders");

Expand Down
3 changes: 2 additions & 1 deletion ...src/test/java/com/facebook/presto/plugin/oracle/DisabledTestOracleDistributedQueries.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
import com.facebook.presto.tests.AbstractTestDistributedQueries;
import io.airlift.tpch.TpchTable;
import org.testng.annotations.AfterClass;
import org.testng.annotations.Optional;
import org.testng.annotations.Test;

import static com.facebook.presto.common.type.VarcharType.VARCHAR;
Expand Down Expand Up @@ -164,7 +165,7 @@ public void testRenameColumn()

@Test
@Override
public void testShowColumns()
public void testShowColumns(@Optional("PARQUET") String storageFormat)
{
MaterializedResult actual = computeActual("SHOW COLUMNS FROM orders");

Expand Down
3 changes: 2 additions & 1 deletion ...c/test/java/com/facebook/presto/plugin/singlestore/TestSingleStoreDistributedQueries.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import com.google.common.collect.ImmutableMap;
import io.airlift.tpch.TpchTable;
import org.testng.annotations.AfterClass;
import org.testng.annotations.Optional;
import org.testng.annotations.Test;

import static com.facebook.presto.common.type.VarcharType.VARCHAR;
Expand Down Expand Up @@ -60,7 +61,7 @@ public final void destroy()
}

@Override
public void testShowColumns()
public void testShowColumns(@Optional("PARQUET") String storageFormat)
{
MaterializedResult actual = computeActual("SHOW COLUMNS FROM orders");

Expand Down
Loading
Loading