Add support for ALTER COLUMN SET DATA TYPE in the Iceberg connector

[NivinCS]

Description

Add support for ALTER COLUMN SET DATA TYPE in the Iceberg connector

Motivation and Context

To address the issue : #25417

Impact

Test Plan

Contributor checklist

• Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
• PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
• Documented new properties (with its default value), SQL syntax, functions, or other functionality.
• If release notes are required, they follow the release notes guidelines.
• Adequate tests were added if applicable.
• CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* Add support for ALTER COLUMN SET DATA TYPE in the Iceberg connector

[github-actions]

Codenotify: Notifying subscribers in CODENOTIFY files for diff 709047e...7b915f5.

Notify	File(s)
@aditi-pandit	presto-parser/src/main/antlr4/com/facebook/presto/sql/parser/SqlBase.g4
@elharo	presto-parser/src/main/antlr4/com/facebook/presto/sql/parser/SqlBase.g4
@kaikalur	presto-parser/src/main/antlr4/com/facebook/presto/sql/parser/SqlBase.g4
@rschlussel	presto-parser/src/main/antlr4/com/facebook/presto/sql/parser/SqlBase.g4

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: dmariamgeorge / name: Deepa Mariam George (7b915f5)

[steveburnett]

LGTM! (docs)

Pull branch, local doc build, looks good. Thanks!

[prestodb-ci]

@imjalpreet imported this issue as lakehouse/presto #25418

[hantangwangd]

Thanks for the work, the whole change overall looks good! Just a few things to address:
1. As I see, the ShortDecimalType -> LongDecimalType conversion (e.g. decimal(10, 2) -> decimal(24, 2)) might cause problems in PARQUET format Iceberg table.
2. Since this change primarily focuses on supporting ALTER COLUMN TYPE in Iceberg, we should add test cases in Iceberg covering all type conversions (int->long, float->double, decimal->decimal, v2-compatible referring here), verifying that both query results and SHOW CREATE TABLE outputs meet expectations. An example test case may look as follows:

    @Test
    public void testAlterColumnType()
    {
        testWithAllFileFormats(this::testAlterColumnType);
    }

    private void testAlterColumnType(Session session, FileFormat fileFormat)
    {
        String schemaName = session.getSchema().get();
        String tableName = "test_alter_column_type_" + randomTableSuffix();
        assertUpdate("CREATE TABLE " + tableName + "(a int, b real, c decimal(4, 2)) with (\"write.format.default\" = '" + fileFormat + "')");
        assertUpdate("INSERT INTO " + tableName + " VALUES(1, 1.1, 1.21)", 1);
        assertUpdate("INSERT INTO " + tableName + " VALUES(2, 2.2, 2.34)", 1);
        assertQuery("SELECT * from " + tableName, "VALUES(1, 1.1, 1.21), (2, 2.2, 2.34)");
        validateShowCreateTable(tableName,
                ImmutableList.of(
                        columnDefinition("a", "integer"),
                        columnDefinition("b", "real"),
                        columnDefinition("c", "decimal(4,2)")),
                getCustomizedTableProperties(ImmutableMap.of(
                        "write.format.default", "'" + fileFormat + "'",
                        "location", "'" + getLocation(schemaName, tableName) + "'")));

        assertUpdate("ALTER TABLE " + tableName + " ALTER COLUMN a SET DATA TYPE bigint");
        assertUpdate("ALTER TABLE " + tableName + " ALTER COLUMN b SET DATA TYPE double");
        assertUpdate("ALTER TABLE " + tableName + " ALTER COLUMN c SET DATA TYPE decimal(10, 2)");
        assertQuery("SELECT * from " + tableName, "VALUES(1, 1.1, 1.21), (2, 2.2, 2.34)");
        validateShowCreateTable(tableName,
                ImmutableList.of(
                        columnDefinition("a", "bigint"),
                        columnDefinition("b", "double"),
                        columnDefinition("c", "decimal(10,2)")),
                getCustomizedTableProperties(ImmutableMap.of(
                        "write.format.default", "'" + fileFormat + "'",
                        "location", "'" + getLocation(schemaName, tableName) + "'")));

        assertUpdate("ALTER TABLE " + tableName + " ALTER COLUMN c SET DATA TYPE decimal(24, 2)");
        assertQuery("SELECT * from " + tableName, "VALUES(1, 1.1, 1.21), (2, 2.2, 2.34)");
        validateShowCreateTable(tableName,
                ImmutableList.of(
                        columnDefinition("a", "bigint"),
                        columnDefinition("b", "double"),
                        columnDefinition("c", "decimal(24,2)")),
                getCustomizedTableProperties(ImmutableMap.of(
                        "write.format.default", "'" + fileFormat + "'",
                        "location", "'" + getLocation(schemaName, tableName) + "'")));

        dropTable(getSession(), tableName);
    }

Please feel free to adopt it or modify it to your needs.

[pratyakshsharma]

Took first pass. One high level comment, we can add documentation as well around this feature on https://prestodb.io/docs/current/sql/alter-table.html and update Iceberg connector with the limitation clearly stating what data type changes are we supporting currently.

[pratyakshsharma]

the check should be reversed here I think.

[pratyakshsharma]

are we expecting one of them to be null here?

[PingLiuPing]

Why ICEBERG_UNKNOWN_TABLE_TYPE ?
Should be unknown column name or incompatible column type.

[pratyakshsharma]

this method is not getting used and can be reverted.

[pratyakshsharma]

nit: this is not getting used.

[pratyakshsharma]

this is not getting used.

[pratyakshsharma]

this as well

[pratyakshsharma]

this can be converted to a local variable.

[pratyakshsharma]

please check intellij suggestions here. There are few variables which can be converted to a local variable. Please do the needful

[PingLiuPing]

A general question, does Presto support alter column type for other connector without this PR?

[PingLiuPing]

Please also add test case to cover the iceberg primitive type promotions.
See https://iceberg.apache.org/spec/#schema-evolution