build: Add Presto native C++ dev container #25358
Conversation
|
@mblanco-denodo, there have been some fixes to the CI tests since the last activity on this PR. If you rebase, these pending tests might pass. |
mblanco-denodo
force-pushed
the
dev_container_c++
branch
from
a1d3f8d to
235dd55
Compare
|
Hi! I've rebased and updated the devcontainer generation to be mounted from CLion, so that it uses the prestissimo dependency image leveraging us from the need to maintain the devcontainer. This should work if the dependency images work. I've also added documentation on how to configure it |
mblanco-denodo
changed the title
steveburnett
left a comment
steveburnett
left a comment
There was a problem hiding this comment.
Thanks for the documentation! I made some suggestions and had questions. Let me know what you think, and ask if anything I wrote is unclear.
mblanco-denodo
force-pushed
the
dev_container_c++
branch
from
d1540a6 to
49afaab
Compare
mblanco-denodo
force-pushed
the
dev_container_c++
branch
from
49afaab to
d312725
Compare
steveburnett
left a comment
steveburnett
left a comment
There was a problem hiding this comment.
Thanks for the doc fixes! One minor suggestion.
mblanco-denodo
force-pushed
the
dev_container_c++
branch
2 times, most recently
from
f9a403f to
68c61fd
Compare
czentgr
left a comment
czentgr
left a comment
There was a problem hiding this comment.
FYI, we also have another devcontainer setup: https://github.com/prestodb/presto-dev
But this is more about integration with CLion.
| # Copy shared libs to the directory /runtime-libraries | ||
| mkdir /runtime-libraries && \ | ||
| bash -c '!(LD_LIBRARY_PATH=${LD_LIBRARY_PATH}:/usr/local/lib:/usr/local/lib64 ldd ../cmake-build-debug/presto_cpp/main/presto_server | grep "not found")' && \ | ||
| LD_LIBRARY_PATH=${LD_LIBRARY_PATH}:/usr/local/lib:/usr/local/lib64 ldd ../cmake-build-debug/presto_cpp/main/presto_server | awk 'NF == 4 { system("cp " $3 " /runtime-libraries") }' No newline at end of file |
| @@ -0,0 +1,6 @@ | |||
| #!/bin/bash | |||
| # Before executing this script, you should compile presto_server | |||
There was a problem hiding this comment.
What happens if you don't. Will CLion throw an error?
There was a problem hiding this comment.
No, this is only to match the release environment, making sure that you're executing the server this the same libraries as the release version. This way, if your compilation lacks any library, you should see failures during the execution before the code is integrated into master
mblanco-denodo
force-pushed
the
dev_container_c++
branch
from
68c61fd to
48f2b73
Compare
4 participants
Description
Added dev container for Presto native C++
Motivation and Context
Ease Presto native C++ development
Impact
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.