Support sorted shuffle write in Sapphire-Velox stack #24739
+900
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This pull request was exported from Phabricator. Differential Revision: D71236519 |
emilysun201309
added a commit
to emilysun201309/presto
that referenced
this pull request
Mar 17, 2025
Summary: Support sorted shuffle write in Sapphire-Velox stack: - Copy the key value serializer: `fbcode/spark_cpp/src/main/serializer/CoscoKeyValueSerializer.h` from Spruce to `github/presto-trunk/presto-native-execution/presto_cpp/main/operators/KeyValueSerializer.h` This is so that we don't have dependency on the internal implementation. - Allow PartitionAndSerialize Node to take `sortingOrder and `sortingKeys` as optional parameters. - If both `sortingOrder and `sortingKeys` are provided, serialize the Keys and invoke Cosco sorted shuffle by providing an non-empty key. Differential Revision: D71236519
emilysun201309
force-pushed
the
export-D71236519
branch
from
3e2bece to
4a8d2ba
Compare
Summary: Pull Request resolved: prestodb#24739 Support sorted shuffle write in Sapphire-Velox stack: - Copy the key value serializer: `fbcode/spark_cpp/src/main/serializer/CoscoKeyValueSerializer.h` from Spruce to `github/presto-trunk/presto-native-execution/presto_cpp/main/operators/KeyValueSerializer.h` This is so that we don't have dependency on the internal implementation. - Allow PartitionAndSerialize Node to take `sortingOrder and `sortingKeys` as optional parameters. - If both `sortingOrder and `sortingKeys` are provided, serialize the Keys and invoke Cosco sorted shuffle by providing an non-empty key. Differential Revision: D71236519
|
This pull request was exported from Phabricator. Differential Revision: D71236519 |
emilysun201309
force-pushed
the
export-D71236519
branch
from
4a8d2ba to
398080a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Support sorted shuffle write in Sapphire-Velox stack:
Copy the key value serializer:
fbcode/spark_cpp/src/main/serializer/CoscoKeyValueSerializer.hfrom Spruce togithub/presto-trunk/presto-native-execution/presto_cpp/main/operators/KeyValueSerializer.hThis is so that we don't have dependency on the internal implementation.
Allow PartitionAndSerialize Node to take
sortingOrder andsortingKeys` as optional parameters.If both
sortingOrder andsortingKeys` are provided, serialize the Keys and invoke Cosco sorted shuffle by providing an non-empty key.Differential Revision: D71236519