Add spill related configs to system configs #24726
Open
+163
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D71002997 |
HeidiHan0000
added a commit
to HeidiHan0000/presto
that referenced
this pull request
Mar 13, 2025
Summary: Adding spill configs so they can be set from configs, and then overridden by session properties. Differential Revision: D71002997
HeidiHan0000
force-pushed
the
export-D71002997
branch
from
269ebb8 to
89736e0
Compare
HeidiHan0000
requested review from
steveburnett,
elharo and
a team
as code owners
|
This pull request was exported from Phabricator. Differential Revision: D71002997 |
steveburnett
previously approved these changes
Mar 17, 2025
tanjialiang
previously approved these changes
Mar 17, 2025
| @@ -162,6 +162,51 @@ The configuration properties of Presto C++ workers are described here, in alphab | |||
| storage used for spilling. If it is zero, then there is no limit and spilling | |||
| might exhaust the storage or takes too long to run. | |||
|
|
|||
|
|
|||
| ``spill-enabled`` | |||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | |||
There was a problem hiding this comment.
The ^^^ should match the length of the title.
|
|
||
|
|
||
| ``join-spill-enabled`` | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ |
|
|
||
|
|
||
| ``aggregation-spill-enabled`` | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ |
|
|
||
|
|
||
| ``order-by-spill-enabled`` | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ |
|
Thanks @HeidiHan0000 , minor formatting issues on the doc. Please address before merge. |
Summary: Adding spill configs so they can be set from configs, and then overridden by session properties. Reviewed By: tanjialiang Differential Revision: D71002997
HeidiHan0000
dismissed stale reviews from tanjialiang and steveburnett
via
6e08831
HeidiHan0000
force-pushed
the
export-D71002997
branch
from
89736e0 to
6e08831
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71002997 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Adding spill configs so they can be set from configs, and then overridden by session properties.
Differential Revision: D71002997