Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plan checker sessionPass ConnectorSession to PlanChecker #24557

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rschlussel
Copy link
Contributor

@rschlussel rschlussel commented Feb 13, 2025

Description

Pass ConnectorSession to PlanChecker and add ConnectorSession.forConnectorId() method.

Motivation and Context

We have a planchecker that calls out to get connector metadata for the tablescan, and so we need to pass the connector session through to those calls

Impact

Updates the plan checker SPI

Test Plan

CI

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

SPI Changes
* Add ConnectorSession as an argument to PlanChecker.validate and PlanChecker.validateFragment 

jaystarshot
jaystarshot previously approved these changes Feb 14, 2025
Add a method forConnectorId to ConnectorSession to allow converting
ConnectorSession of one connector to a ConnectorSession for another
connector.
This allows the planchecker to pass the ConnectorSession to any
connector calls that it makes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:Meta PR from Meta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants