[Parquet]Fix writing columns with all null values after row group flush #24555
+71
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fix a bug in parquet which cased the flaky #22907. The core reason is that, when Parquet writes a data page with a column that is all null right after row group level flush, the handling of that column is incorrect: its encoding still uses dictionary encoding, but no dictionary page is output.
Motivation and Context
Fix #22907
Impact
N/A
Test Plan
TestParquetWriter.testWriteAllNullDataPageAfterRowGroupFlush()
which can reproduce the issue without this change.testSingleLevelSchemaArrayOfArrayOfStructOfArray()
to 1024, and make sure the issue do not appear anymore.Contributor checklist
Release Notes