Adding default value to verify hostname #24552
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This issue was identified as part of addressing a SonarQube warning in a static scan. The warning, 'Enable server hostname verification on this SSL/TLS connection,' was found in PrometheusClient.java. Upon investigation, we determined it to be a false positive.
This change adds a default value to the configuration property verify-host-name, which can be passed from the Preso UI. Based on this configuration value, a hostnameVerifier object is created. If the configuration property is set to false, the hostname verifier is adjusted to accept all hostnames; otherwise, it will perform hostname verification. To enable hostname verification by default, we are setting the verifyHostName variable to true in the PrometheusConnectorConfig.java file
Test Plan
Contributor checklist
Release Notes