improve boostrap log to expose the wrong classLoader #24533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericyuliu
requested review from
jaystarshot,
feilong-liu,
ClarenceThreepwood and
a team
as code owners
|
This pull request was exported from Phabricator. Differential Revision: D69416153 |
Summary: T214943360 Impulse class loader issue causing bootstrap exception Prev Caused by: java.lang.IllegalArgumentException: Expected com.facebook.presto.$gen.WeightedAverageStateSerializer_20250210_222951_7's classloader to be of type com.facebook.presto.bytecode.DynamicClassLoader, but is com.facebook.presto.bytecode.DynamicClassLoader Differential Revision: D69416153
ericyuliu
force-pushed
the
export-D69416153
branch
from
387ac9e to
659077c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69416153 |
|
nit: capitalize the commit title and remove references to internal connectors. |
|
Looks like you need a rebase to fix the maven checks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Previou exception message does not explain the wrong classloader.
Root cause:
Impulse code is not executed within a context class loader. There is a chance some classes may be loaded by a connector specific class loader.
New message:
Caused by: java.lang.IllegalArgumentException: Expected com.facebook.presto.$gen.WeightedAverageStateSerializer_20250210_222951_7's classloader to be of type com.facebook.presto.bytecode.DynamicClassLoader, but is com.facebook.presto.bytecode.DynamicClassLoader
Differential Revision: D69416153