Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI workflows #223

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Update CI workflows #223

merged 2 commits into from
Jun 3, 2024

Conversation

mvanderkamp
Copy link
Member

@mvanderkamp mvanderkamp commented Nov 19, 2023

Problem

The CI workflows are failing or not getting picked up by runners.

Vint

Failing:

Run vint .
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.12.0/x64/bin/vint", line 5, in <module>
    from vint import main
  File "/opt/hostedtoolcache/Python/3.12.0/x64/lib/python3.12/site-packages/vint/__init__.py", line 1, in <module>
    from vint.bootstrap import (
  File "/opt/hostedtoolcache/Python/3.[12](https://github.com/preservim/vimux/actions/runs/6923608934/job/18831713393?pr=222#step:5:13).0/x64/lib/python3.12/site-packages/vint/bootstrap.py", line 5, in <module>
    from vint.linting.cli import CLI
  File "/opt/hostedtoolcache/Python/3.12.0/x64/lib/python3.12/site-packages/vint/linting/cli.py", line 4, in <module>
    import pkg_resources
ModuleNotFoundError: No module named 'pkg_resources'
Error: Process completed with exit code 1.

Check

Not being picked up:

Requested labels: ubuntu-18.04
Job defined at: preservim/vimux/.github/workflows/check.yml@refs/pull/222/merge
Waiting for a runner to pick up this job...

Solution

Let's try updating the actions.

Trying to run on ubuntu 18 is failing to be picked up by any runners
@mvanderkamp
Copy link
Member Author

I think the incomplete actions on this PR are the ones that are defined on master, since they include specific ubuntu versions in their matrix. They don't show up in the Actions tab though. My guess is, those checks are defined as required in the branch protections. @alerque are you able to check the settings?

Also is there a reason we specifically were testing on ubuntu 18?

@mvanderkamp mvanderkamp changed the title Update actions Update CI workflows Feb 19, 2024
@mvanderkamp
Copy link
Member Author

@alerque Can you adjust the branch protections so that this repo isn't blocked waiting for checks that will never complete?

@alerque alerque merged commit 5738a47 into master Jun 3, 2024
8 checks passed
@alerque alerque deleted the update-actions branch June 3, 2024 08:46
@alerque
Copy link
Member

alerque commented Jun 3, 2024

I don't know why this didn't land on my radar (I probably dismissed notifications too quickly in some batch) but thanks for the contribution. I'll check the required tests after this is in master and hence picked up by the required checks interface.

@mvanderkamp
Copy link
Member Author

mvanderkamp commented Jun 3, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants