Add Nutils participants for turek-hron-fsi3 #648
Conversation
gertjanvanzwieten
force-pushed
the
nutils-turek
branch
from
1dfe1ab to
5e39606
Compare
|
I ran both scripts through autopep8 -i but the style check is still failing. Please advise :) |
Thanks for the PR, @gertjanvanzwieten! |
gertjanvanzwieten
force-pushed
the
nutils-turek
branch
from
5e39606 to
2f77bfb
Compare
|
For some reason actions fail to kick in but I think the scripts are compliant now, changes are generated with pre-commit run. |
There was a problem hiding this comment.
Thanks @gertjanvanzwieten for this nice and clean contribution ❤️ and sorry for the very late reply.
Could you please tick the box in the PR to allow edits from maintainers?
The scripts are only tested in mutual coupling, so I don't know how they hold up with other participants
For how long did you run the simulation. Only the first few timesteps or till the end? If the latter, did you get identical results compared to the monolithic one?
I was able to start Nutils-Nutils and the first few time steps converged. Now I am running OpenFOAM-Nutils for longer to check physical results.
TODO (for us):
- add participants to README
| cons['d'][r_where] = participant.read_data( | ||
| r_name, 'Displacement', r_ids, timestep) |
There was a problem hiding this comment.
Just to confirm: You are using Newmark-beta for time integration. This means, you want to read at the end of the time step size, right? This is what is done right now.
| @dataclass | ||
| class DummyParticipant: |
There was a problem hiding this comment.
Did you use this mock for testing? Is it still required?
| args['traction'] = participant.read_data( | ||
| rw_name, 'Stress', rw_ids, timestep) |
There was a problem hiding this comment.
Again reading at the end of the time step. Is this what you want here?
This PR adds two Nutils participants for the turek-hron-fsi3 tutorial. The scripts are intentionally structured similar to our monolithic example so they can be compared side by side with https://examples.nutils.org/official-turek/.
Some notes:
I hope you will find this a useful addition, let me know if anything needs changing!