Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robust mapping-tester plotting #228

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Robust mapping-tester plotting #228

wants to merge 2 commits into from

Conversation

fsimonis
Copy link
Member

@fsimonis fsimonis commented Feb 6, 2025

Main changes of this PR

This PR changes the mapping-tester plotting by

  • migrating to polars
  • refactoring the whole code
  • making it more robust
    • it ignores plots for missing columns which happens when only measuring runtime
    • it only uses a log axis if it is numerical
  • adding runtime-accuracy plots

The plotting will now work for the current mapping tester examples even though the meshes are not made for this use-case.
We would have to rename them to using element size and adding at least two meshes as 'mesh A'.

Author's checklist

  • I used the pre-commit hook and used pre-commit run --all to apply all available hooks.
  • I added a test to cover the proposed changes in our test suite.
  • I updated the documentation in docs/README.md.
  • I added a changelog entry in ./changelog-entries/ (create if necessary).
  • I updated potential breaking changes in the tutorial precice/tutorials/aste-turbine.

@fsimonis fsimonis self-assigned this Feb 6, 2025
@fsimonis fsimonis requested a review from davidscn February 6, 2025 10:11
Copy link
Member

@davidscn davidscn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still have the (optional) plotting of comparison slopes of a specific order? e.g. second order curve?

tools/mapping-tester/plotconv.py Show resolved Hide resolved
tools/mapping-tester/plotconv.py Outdated Show resolved Hide resolved
@fsimonis
Copy link
Member Author

fsimonis commented Feb 6, 2025

I noticed that the slopes have been disabled quite some time ago. IIRC they needed so much manual fine-tuning, that it was easier to hack them into the final output then integrate it into the script itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants