Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove JS comments between JSXAttributes #828

Merged
merged 1 commit into from
Sep 2, 2021
Merged

Conversation

marvinhagemeister
Copy link
Member

This PR addresses an issue where htm would detect the starting slash of a JS comment as the closing character for the current JSX Element. This leads to props being ignored during rendering.

The solution is to drop comments when transforming JSX to htm.

Fixes #826

@changeset-bot
Copy link

changeset-bot bot commented Sep 1, 2021

🦋 Changeset detected

Latest commit: 221c8fe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wmr Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2021

Size Change: +272 B (0%)

Total Size: 805 kB

Filename Size Change
packages/wmr/wmr.cjs 767 kB +272 B (0%)
ℹ️ View Unchanged
Filename Size
examples/demo/dist/about/index.html 713 B
examples/demo/dist/alias-outside/index.html 693 B
examples/demo/dist/assets/Calendar.********.css 702 B
examples/demo/dist/assets/style.********.css 624 B
examples/demo/dist/chunks/alias-outside.********.js 137 B
examples/demo/dist/chunks/class-fields.********.js 213 B
examples/demo/dist/chunks/compat.********.js 15.3 kB
examples/demo/dist/chunks/hoofd.module.********.js 1.48 kB
examples/demo/dist/chunks/index.********.js 266 B
examples/demo/dist/chunks/json.********.js 238 B
examples/demo/dist/chunks/meta-tags.********.js 296 B
examples/demo/dist/chunks/prerender.********.js 2.43 kB
examples/demo/dist/class-fields/index.html 704 B
examples/demo/dist/compat/index.html 1.55 kB
examples/demo/dist/env/index.html 779 B
examples/demo/dist/error/index.html 708 B
examples/demo/dist/files/index.html 738 B
examples/demo/dist/index.********.js 7.67 kB
examples/demo/dist/index.html 770 B
examples/demo/dist/json/index.html 711 B
examples/demo/dist/lazy-and-late/index.html 714 B
examples/demo/dist/meta-tags/index.html 778 B

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comments between JSX attributes lead to props being ignored
1 participant