Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle Rollup defs into TypeScript definition before publishing #519

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

developit
Copy link
Member

The implementation here is super ridiculous, I know.

I tried all of the d.ts bundlers I could find, and none of them were able to handle ambient declarations within types to be bundled. Our types have them, but some of the types we depend on do as well (a connect middleware that is a dependency of Polka's types).

Originally I had built this to inline 100% of our type deps, but I don't think that approach can be made to function correctly. Instead, since we already scaffold projects with Automatic Type Acquisition, I've limited the inlining to only module-provided definitions (no @types/*) - effectively, only rollup.

Since it's just rollup, maybe a better solution here would be to have a build script inline Rollup's d.ts (which is already in node_modules and has no dependencies).

@developit developit added the infra testing, CI & deployment label Apr 1, 2021
@changeset-bot
Copy link

changeset-bot bot commented Apr 1, 2021

⚠️ No Changeset found

Latest commit: 3254f36

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra testing, CI & deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant