Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci pipeline with windows and os matrix #13

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

AlexMikhalev
Copy link
Contributor

Hello all,
I have seen marker help needed on #6 and tried copy-pasting from Aho-corasick pipeline and this gist

Signed-off-by: Alex Mikhalev <[email protected]>
Signed-off-by: Alex Mikhalev <[email protected]>
Signed-off-by: Alex Mikhalev <[email protected]>
Actions fail as treat editions 2018 as unstable
cargo-features = ["edition"] added
Too much time needs for debugging
Signed-off-by: Alex Mikhalev <[email protected]>
Signed-off-by: Alex Mikhalev <[email protected]>
@prataprc prataprc changed the title Ci pipeline wiht windows and os matrix Ci pipeline with windows and os matrix Dec 22, 2020
@prataprc
Copy link
Owner

Not that I am expert in git-workflow.. but workflow seem to be good. We will merge it. Btw, I am seeing some modifications to Cargo.toml and bench-code. May be rustfmt ? Can we consolidate the changes into two commits,
a. one for workflow.
b. another for rustfmt and other changes to Cargo.toml.

You can try git rebase to fuse commits.

Thanks,

@AlexMikhalev
Copy link
Contributor Author

AlexMikhalev commented Dec 22, 2020 via email

@AlexMikhalev
Copy link
Contributor Author

Actually, fmt changes are part of this commit intentionally (and I reverted any changes to Cargo.toml) - without those changes pipeline will fail. I.e. if you only merge commit with pipeline it will instantly fail as bench code isn't fmt standard.

@prataprc
Copy link
Owner

Its okay if it is not fmt standard. We can fix it later. As long as functionality and benchmarks work, we are okay. May be only think you may want to do is to consolidate commits. Thanks,

	Cargo.toml
	benches/src/xor_bench.rs
Signed-off-by: Alex Mikhalev <[email protected]>
@prataprc prataprc force-pushed the master branch 8 times, most recently from c4c886e to 859aaf4 Compare October 3, 2021 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants