-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ci pipeline with windows and os matrix #13
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Alex Mikhalev <[email protected]>
Signed-off-by: Alex Mikhalev <[email protected]>
Signed-off-by: Alex Mikhalev <[email protected]>
Actions fail as treat editions 2018 as unstable
cargo-features = ["edition"] added
Too much time needs for debugging
Signed-off-by: Alex Mikhalev <[email protected]>
Signed-off-by: Alex Mikhalev <[email protected]>
Not that I am expert in git-workflow.. but workflow seem to be good. We will merge it. Btw, I am seeing some modifications to Cargo.toml and bench-code. May be rustfmt ? Can we consolidate the changes into two commits, You can try Thanks, |
Cargo.toml changes should have been reverted.
A
…On Tue, 22 Dec 2020 at 12:10, prataprc ***@***.***> wrote:
Not that I am expert in git-workflow.. but workflow seem to be good. We
will merge it. Btw, I am seeing some modifications to Cargo.toml and
bench-code. May be rustfmt ? Can we consolidate the changes into two
commits,
a. one for workflow.
b. another for rustfmt and other changes to Cargo.toml.
You can try git rebase to fuse commits.
Thanks,
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#13 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAML7IKFNYXT6MAJZKGHXTSWCEBXANCNFSM4VEW3I6A>
.
|
Actually, fmt changes are part of this commit intentionally (and I reverted any changes to Cargo.toml) - without those changes pipeline will fail. I.e. if you only merge commit with pipeline it will instantly fail as bench code isn't fmt standard. |
Its okay if it is not fmt standard. We can fix it later. As long as functionality and benchmarks work, we are okay. May be only think you may want to do is to consolidate commits. Thanks, |
Cargo.toml benches/src/xor_bench.rs
Signed-off-by: Alex Mikhalev <[email protected]>
c4c886e
to
859aaf4
Compare
Hello all,
I have seen marker help needed on #6 and tried copy-pasting from Aho-corasick pipeline and this gist