-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Neg num of ques #131
base: main
Are you sure you want to change the base?
Neg num of ques #131
Conversation
✅ Deploy Preview for arito ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations on your First Pull Request! Wish you best on your open-source journey 😊
Kindly review this PR. Thank you |
2 similar comments
Kindly review this PR. Thank you |
Kindly review this PR. Thank you |
Great job @nishita2104! |
sure! |
@prakhartiwari0 This is what it looks like after modification: |
Fixes #112
Describe the changes you've made
I have added an if condition in the getValues() function in main.js file. This if condition checks if the amount of questions is not between 1 and 56, then it displays the said error.
To display the error in the app itself (to avoid using alerts), 2 more functions are made namely showError and clearError. These functions help display the error and clear it when error is fixed, i.e. correct number of questions is entered.
Type of change
What sort of change have you made:
How Has This Been Tested?
I entered several possible error cases in the number of questions column and each time the error message was displayed. The test starts if the number of questions entered is between 1 and 56.
Checklist:
Screenshots (Images)