test: add validate test

ppzqh · Aug 8, 2024 · ca3293f · ca3293f
1 parent 46d8496
commit ca3293f
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 4 deletions.
diff --git a/pkg/remote/codec/validate.go b/pkg/remote/codec/validate.go
@@ -104,10 +104,6 @@ func (p *crcPayloadValidator) Key(ctx context.Context) string {
 	return transmeta.HeaderCRC32C
 }
 
-func (p *crcPayloadValidator) Checksum(ctx context.Context, payload []byte) (value string, err error) {
-	return getCRC32C([][]byte{payload}), nil
-}
-
 func (p *crcPayloadValidator) Generate(ctx context.Context, outPayload []byte) (need bool, value string, err error) {
 	return true, getCRC32C([][]byte{outPayload}), nil
 }

diff --git a/pkg/remote/codec/validate_test.go b/pkg/remote/codec/validate_test.go
@@ -3,7 +3,9 @@ package codec
 import (
 	"context"
 	"github.com/bytedance/gopkg/util/xxhash3"
+	"github.com/cloudwego/kitex/internal/test"
 	"strconv"
+	"testing"
 )
 
 var _ PayloadValidator = &mockPayloadValidator{}
@@ -35,3 +37,16 @@ func (m *mockPayloadValidator) Validate(ctx context.Context, expectedValue strin
 	}
 	return value == expectedValue, nil
 }
+
+func TestPayloadValidator(t *testing.T) {
+	p := &crcPayloadValidator{}
+	payload := make([]byte, 0)
+
+	need, value, err := p.Generate(context.Background(), payload)
+	test.Assert(t, err == nil, err)
+	test.Assert(t, need)
+
+	pass, err := p.Validate(context.Background(), value, payload)
+	test.Assert(t, err == nil, err)
+	test.Assert(t, pass, true)
+}