Add style options to dynamic skin elements #31100
Conversation
| // We only have bold weight for venera, so let's force that. | ||
| FontWeight fontWeight = typeface.NewValue == Typeface.Venera ? FontWeight.Bold : FontWeight.Regular; | ||
|
|
||
| FontUsage f = OsuFont.GetFont(typeface.NewValue, weight: fontWeight); |
There was a problem hiding this comment.
In master this particular piece of code is copied once. This PR adds four more copies. That's definitely past the threshold of "not sure if it's fine to copy this logic" - it's not.
This can probably go live in OsuFont itself. Compare:
osu/osu.Game/Graphics/OsuFont.cs
Lines 86 to 88 in 9652c5a
|
Visually not sure on the execution either. Most of the components seem to be designed with a heavy lean on venera's aesthetic and metrics to visually work. With other fonts things just kinda don't work. Although I guess there is an option to switch labels off and usually it's the labels that look bad... Like look at the screenshots below. Counter text & label text misaligned:
Ascenders protruding past counter that look bad, not sure on the lowercase use either:
cc @ppy/team-design maybe |
|
I moved the venera bold check to As for the visual concerns, I'm not entirely sure if I should fix it, or wait for other opinions from the design team. |
This pr adds style options:
Font,TextColour, andShowLabel, to a few dynamic skin elements.The skin elements being:
BPMCounter.ClicksPerSecondCounter,LongestComboCounterandUnstableRateCounter.Made this to make these elements less restrictive and add more customization to the skin editor.
Preview:
