Add suboption to Hidden (HD) for decreasing visibility based on combo #31087
Conversation
|
I dunno if we want this in the game. Leaning no by default unless there is actual support. |
|
Thanks for taking a look.
Support from whom? Apart from your input, I’ve only seen neutral or positive reactions in both the GitHub Discussion and the Development Discord Server. Since the option is disabled by default, it would be unintrusive to players. Additionally, the concept of adjusting a mod's difficulty based on player performance is already well-established in the game. Even some ranked mods, like Blinds, have similar mechanics. (Also, I don’t necessarily want this option to be ranked.) Personally, I believe this feature offers a great way to ease into playing the hidden mod or practicing beatmaps with it enabled. Are there specific concerns you have with the concept, the behavior of the implementation, or the code itself? Also, I am aware of the failing CI tests. I will look into these in the following two weeks. |
I have only one concern and it's very simple: it's extra complexity and I don't want extra complexity if there isn't a very good reason for it. What you got in terms of support is 2 upvotes (not counting yourself) on the discord discussion. I'm not sure what happened on discord because it's an ephemeral communication medium in my mind and I don't 100% keep up with it. I would want to see a considerably higher number of supporters in order to consider adding this feature. |
|
Is this enough support? |
|
Results look 50-50ish. I'm not particularly positively swayed by that result, so I guess not. |
I only added negative voting options for statistical/transparancy purposes and I don't think that the ratio should serve as an argument for weither the feature should be implemented. The reason is, that the feature is disabled by default and the only other effect is a second control for this mods preferences-menu. Nobody can seriously be disrupted by this. So the only reasons for people to vote against are:
Apart from the last one, these are not valid arguments adding this feature. And as for complexity, almost every addition adds complexity. And I think in this case, where it's just in a corner of the codebase and well documented by me, this argument looks weak. In conclusion, counting all sources there have already been more than 10 people expressing support for this (i admit partially because of me promoting it on various channels), which is the only useful metric we got, so why can't we move forward with this? |
|
Looks cool but having some circles not hidden shouldn't have the HD score multiplier bonus and the score bonus should also adjust based on how Hidden the circles are. Otherwise, this will give players an advantage when they combo break and that will be unfair for all the old HD scores that also combo broke. It's kinda complicated but if you manage to do that, then this'll make Hidden playable for everybody. I'm fine with this being added if you address my concerns. |
|
I am happy you like the concept, but there are a few problems with your
suggestion. First of all, I intend score to be unranked with a 1x
multiplier when the feature is enabled. Refer to the image I linked in my
last comment. It's handled the same way with non-default flashlight sizes,
so it gives no advantage over other scores.
In my opinion plays with different mods are just not comparable, so it is
hard for me to come up with how to calculate the score multiplier.
There would be some limitations however:
* No score multiplier based on the beatmap; the osu team is absolutely
against this as it increases complexity tremendously.
* (I assume) No score multiplier based on the play, because it has a similarly
high complexity.
So it would be up to 3rd parties to rank different plays of this kind (but
I am not sure if osu offers apis for this)
There is however a toggle in lazers beatmap selection page for only showing
plays with the selected currently mods and their preferences in
leaderboards. It's only available to supporters though. It would make sense
to offer only allow a few options (like 0, 5, 10, 15) for the combo at
which hit objects are hidden, so more scores can be shown when filtering.
In conclusion what you are suggesting is cool, but for now out of scope for
this PR. For now I intend it to be played for fun and for easing into
starting to play with hd or easing into starting to play new beatmap with
hd.
ominoussage ***@***.***> schrieb am Di., 24. Dez. 2024, 03:18:
… Looks cool but having some circles not hidden shouldn't have any score
multiplier bonus and the score bonus should also adjust based on how Hidden
the circles are.
It's kinda complicated but if you manage to do that, then this'll make
Hidden playable for everybody.
—
Reply to this email directly, view it on GitHub
<#31087 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQAACNG3Y56MZ5EEZSVKKRT2HDAAVAVCNFSM6AAAAABTORKUAWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRQGU2DMMBSHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Video:
https://www.youtube.com/watch?v=Hc0kffA_Ewk
This implementation addresses #30871 for osu!std.
When a player's combo breaks, all approach circles on the screen become visible. As the player's combo increases again, the visibility of new approach circles gradually decreases until they disappear completely once the combo reaches the value specified by the player. The mod tracks and uses an internal combo value that is influenced solely by the results of HitCircles and SliderHeads.
This behavior can also be easily adapted for hidden mods in other rulesets. ModHidden handles most of the necessary logic and provides extensions for implementers to adjust key aspects, after which they only need to apply the opacity provided by ModHidden.