Skip to content

Fail early if crac is not valid #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2025
Merged

Fail early if crac is not valid #979

merged 2 commits into from
Apr 7, 2025

Conversation

obrix
Copy link
Member

@obrix obrix commented Apr 4, 2025

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • A PR or issue has been opened in all impacted repositories (if any)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

Fail and throw exception when reading the crac if it is invalid instead of waiting for rao run.

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

@obrix obrix requested a review from HugoKulesza April 4, 2025 14:50
@obrix obrix force-pushed the early_crac_failure branch from 617dc9d to b7651a4 Compare April 4, 2025 14:50
Signed-off-by: Bertrand Rix <[email protected]>
Copy link

sonarqubecloud bot commented Apr 4, 2025

Copy link

sonarqubecloud bot commented Apr 4, 2025

@HugoKulesza HugoKulesza merged commit fd7f452 into main Apr 7, 2025
10 checks passed
@HugoKulesza HugoKulesza deleted the early_crac_failure branch April 7, 2025 06:49
nao1345678 pushed a commit that referenced this pull request Apr 10, 2025
Signed-off-by: Bertrand Rix <[email protected]>
Signed-off-by: Naledi EL CHEIKH <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants