-
Notifications
You must be signed in to change notification settings - Fork 29
WIP: Manual schema management API #290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
davidmartos96
wants to merge
15
commits into
powersync-ja:main
Choose a base branch
from
davidmartos96:raw_tables_skilldevs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
cea388b
Start integrating Rust extension
simolus3 1421bb6
Add new sync implementation
simolus3 88923e9
Use in-memory sync tests
simolus3 814bade
Properly copy options
simolus3 d104fd2
Revert intended changes
simolus3 b1dbad1
Fix start invocation
simolus3 c635e6b
raw tables in schema
js2702 af052b0
fix tests
davidmartos96 bf9f1e9
manual schema management
davidmartos96 54cf1b9
name params
davidmartos96 d287e3d
pass schema to sync worker
js2702 58de160
review comments
js2702 62f87e6
Merge remote-tracking branch 'origin/main' into raw_tables_skilldevs
davidmartos96 23d6ffa
remove todo
davidmartos96 4abeb7b
format
davidmartos96 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not super happy with this design, but I don't see a better option either.
One thing that looks cleaner might be to have users open their own databases (from
sqlite_async
), initialize the schema there and then pass the database toPowerSyncDatabase.withDatabase
. But that would make the database tricky to use with wrappers like drift because we can't swap out the earlier database with the other one later.So this might be the best option we have here, but I'll ping @rkistner for API design advice as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One issue I can see with that is that the developer wouldn't be able to call
powersyncDB.updateSchema()
because they can only use the sqlite_async API at that point