Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main obstacle here is solving the following (
low_addr
is known,inverse
is not):(inverse * (low_addr - 65532) - 1) * (low_addr - 65532) = 0;
This is similar to #2619 but not exactly (maybe we can still combine both):
We try to solve both branches. The RHS just gives us a range constraint
low_addr = 65532
- butlow_addr
was already known (not that this only works for the "only concrete known is known").On the LHS we can only do the division if we know that
low_addr - 65532
is not zero.This is a slight problem with the new data structures, since we need to solve one branch in the "only concrete is known" version and the other branch in the "also symbolically known is known" version.