More robust publics implementation for WriteOnceMemory
#2600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR improves the robustness of the publics handling in the WriteOnceMemory machine by explicitly detecting the WriteOnceMemoryWith8Publics case. Key changes include:
- Adding new fields (exposes_8_publics and namespace) to drive the special publics behavior.
- Refactoring witness value retrieval into a new get_witness_values() method.
- Updating the take_public_values() logic to handle the WriteOnceMemoryWith8Publics case.
| .iter() | ||
| .enumerate() | ||
| .map(|(value_index, poly)| { | ||
| let column = self.fixed_data.witness_cols[poly] |
There was a problem hiding this comment.
The get_witness_values() method references 'self.fixed_data', but 'fixed_data' is no longer stored in the WriteOnceMemory struct. Consider either adding 'fixed_data' as a field in the struct or passing it as an argument to get_witness_values() to avoid a potential compile error.
Suggested change
| let column = self.fixed_data.witness_cols[poly] | |
| let column = fixed_data.witness_cols[poly] |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
|
@georgwiese do we still want to merge this? |
|
Depends on whether we merge #2572 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A suggestion to #2572.
The previous implementation assumed that only the instance of
WriteOnceMemoryhas publics. Here, we detect theWriteOnceMemoryWith8Publicscase more explicitly.