[WIP] Block machine: only use JIT on Goldilocks #2541
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgwiese
force-pushed
the
block-only-jit2
branch
from
ca20f6d to
c75f078
Compare
This was referenced Mar 13, 2025
georgwiese
force-pushed
the
block-only-jit2
branch
2 times, most recently
from
1196ce3 to
5b9575c
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 13, 2025
Extracted from #2541 Fixes a bug that the machine parts doesn't include the intermediate definitions that only appear in one of the receives. An example of this is the [Arith large](https://github.com/powdr-labs/powdr/blob/main/std/machines/large_field/arith.asm) machine, which has intermediates like `x1c` in their list of arguments, but doesn't refer to the in any constraint. --------- Co-authored-by: chriseth <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 14, 2025
Extracted from #2541 This makes JIT witgen work for the sqrt example.
georgwiese
force-pushed
the
block-only-jit2
branch
from
5b9575c to
8d80f9c
Compare
georgwiese
force-pushed
the
block-only-jit2
branch
5 times, most recently
from
711c83f to
91d870e
Compare
georgwiese
changed the base branch from
use-compute-from
to
block-only-jit-base
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 91d870e | Previous: b9ff8cf | Ratio |
|---|---|---|---|
jit-witgen-benchmark/jit_witgen_benchmark |
40470810431 ns/iter (± 146383195) |
30505971932 ns/iter (± 143565764) |
1.33 |
This comment was automatically generated by workflow using github-action-benchmark.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 18, 2025
This PR changes the usage of `std::prover::provide_value` in `Keccakf32Memory` to `std::prover::compute_from`, in the hope of being able to use the JIT for this machine in #2541. ~Witgen time goes of `test_data/std/keccakf32_memory_test.asm` from 60s to 76s, probably because too many things are being evaluated.~ This is fixed by 1c15647.
georgwiese
force-pushed
the
block-only-jit2
branch
from
c20c57a to
789c0ac
Compare
georgwiese
changed the base branch from
block-only-jit-base
to
inline-witness-assignments
georgwiese
force-pushed
the
block-only-jit2
branch
from
789c0ac to
50ceab8
Compare
|
@georgwiese do we still want this? |
|
I think Chris has merged something similar already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #2553
Like #2540, but falls back to run-time witgen on fields other than Goldilocks.