test: Add unit and pytest tests, coverage config, and Makefile targets

.github/py-shiny/setup/action.yaml

@@ -12,16 +12,19 @@ runs:
         uses: actions/setup-python@v5
         with:
           python-version: ${{ inputs.python-version }}
+          cache: 'pip'
 
       - name: Upgrade `pip`
         shell: bash
         run: |
           python -m pip install --upgrade pip
 
+      # https://github.com/astral-sh/uv/blob/main/docs/guides/integration/github.md
       - name: Install `uv`
-        shell: bash
-        run: |
-          pip install uv
+        uses: astral-sh/setup-uv@v4
+        with:
+          enable-cache: true
+          cache-dependency-glob: "pyproject.toml"
 
       # https://github.com/astral-sh/uv/blob/main/docs/guides/integration/github.md#using-uv-pip
       - name: Allow uv to use the system Python by default

.github/workflows/pytest.yaml

@@ -14,6 +14,7 @@ on:
 jobs:
   check:
     runs-on: ${{ matrix.os }}
+    timeout-minutes: 30
     strategy:
       matrix:
         # "3.10" must be a string; otherwise it is interpreted as 3.1.
@@ -39,10 +40,25 @@ jobs:
         with:
           python-version: ${{ matrix.python-version }}
 
-      - name: Run unit tests
-        if: steps.install.outcome == 'success' && (success() || failure())
+      - name: Run unit tests with coverage
+        if: steps.install.outcome == 'success' && (success() || failure()) && matrix.os == 'ubuntu-latest' && matrix.python-version == '3.12'
+        run: |
+          python -m pytest tests/pytest/ --cov=shiny --cov-report=xml -q
+
+      - name: Run unit tests without coverage
+        if: steps.install.outcome == 'success' && (success() || failure()) && (matrix.os != 'ubuntu-latest' || matrix.python-version != '3.12')
         run: |
-          make check-tests
+          python -m pytest tests/pytest/ -q
+
+      - name: Upload coverage reports to Codecov
+        if: steps.install.outcome == 'success' && (success() || failure()) && matrix.os == 'ubuntu-latest' && matrix.python-version == '3.12'
+        uses: codecov/codecov-action@v5
+        with:
+          files: ./coverage.xml
+          flags: unittests
+          name: codecov-umbrella
+          fail_ci_if_error: false
+          verbose: true
 
       - name: Type check
         if: steps.install.outcome == 'success' && (success() || failure())

Makefile

@@ -179,6 +179,7 @@ clean-js: FORCE
 SUB_FILE:=
 PYTEST_BROWSERS:= --browser webkit --browser firefox --browser chromium
 PYTEST_DEPLOYS_BROWSERS:= --browser chromium
+PYTEST_XDIST?= -n auto
 
 
 # Full test path to playwright tests
@@ -222,10 +223,25 @@ playwright-examples: FORCE
 playwright-ai: FORCE
 	$(MAKE) playwright TEST_FILE="$(AI_TEST_FILE)"
 
-coverage: FORCE ## check combined code coverage (must run e2e last)
-	pytest --cov-report term-missing --cov=shiny tests/pytest/ $(SHINY_TEST_FILE) $(PYTEST_BROWSERS)
-	coverage html
-	$(BROWSER) htmlcov/index.html
+coverage: FORCE ## check unit test coverage (HTML + term)
+	$(MAKE) coverage-unit
+
+coverage-unit: FORCE ## check unit test coverage only (HTML + term)
+	pytest tests/pytest/ $(PYTEST_XDIST) --cov=shiny --cov-report=term-missing --cov-report=html
+	coverage combine
+	@echo "Coverage report: htmlcov/index.html"
+
+coverage-check: FORCE ## check coverage meets minimum threshold
+	pytest tests/pytest/ --cov=shiny --cov-fail-under=25
+
+# CI coverage report: generates both HTML and term reports for CI environments
+coverage-ci: FORCE ## generate unit test coverage reports for CI (HTML + term)
+	@echo "-------- Running tests with coverage --------"
+	pytest tests/pytest/ $(PYTEST_XDIST) --cov=shiny --cov-report=html --cov-report=term
+	coverage combine
+	@echo "Coverage HTML report: htmlcov/index.html"
+	@echo "-------- Coverage Report Summary --------"
+	coverage report
 
 release: dist ## package and upload a release
 	twine upload dist/*

pyproject.toml

@@ -174,3 +174,56 @@ skip = [
 # Note: This setting can not be done via CLI and must be set within a config
 ignore_errors = true
 exclude = ["shiny/api-examples", "shiny/templates"]
+
+[tool.coverage.run]
+source = ["shiny"]
+branch = true
+parallel = true
+concurrency = ["multiprocessing"]
+omit = [
+    "shiny/api-examples/*",
+    "shiny/templates/*",
+    "shiny/www/*",
+    "shiny/_version.py",
+]
+
+[tool.coverage.report]
+exclude_lines = [
+    "pragma: no cover",
+    "def __repr__",
+    "raise NotImplementedError",
+    "if TYPE_CHECKING:",
+    "if typing.TYPE_CHECKING:",
+    "@overload",
+    "@typing.overload",
+    "\\.\\.\\.",  # Ellipsis in stub files
+    # Exclude import statements
+    "^import ",
+    "^from .* import ",
+    # Exclude TypedDict and Protocol definitions (type-only code)
+    "class .*\\(TypedDict\\):",
+    "class .*\\(.*TypedDict.*\\):",
+    "class .*\\(Protocol\\):",
+    "class .*\\(.*Protocol.*\\):",
+    # Exclude type aliases and TypeVar
+    "^[A-Z][a-zA-Z0-9_]* = ",
+    ".* = TypeVar\\(",
+    ".* = Union\\[",
+    # Exclude __all__ definitions
+    "^__all__ = ",
+    # Exclude sentinel/marker class definitions
+    "^class [A-Z_]+:",
+    "^    pass$",
+    # Exclude docstrings (triple-quoted strings)
+    '"""',
+    "'''",
+]
+# Note: show_missing is intentionally not set to true by default.
+# Using `--cov-report=term-missing` with the full shiny source causes
+# coverage report generation to be extremely slow. Use HTML reports
+# or targeted term-missing reports on specific modules instead.
+precision = 2
+fail_under = 25
+
+[tool.coverage.html]
+directory = "htmlcov"

pytest.ini

@@ -6,3 +6,8 @@ testpaths=tests/pytest/
 ; Note: Browsers are set within `./Makefile`
 addopts = --strict-markers --durations=6 --durations-min=5.0 --numprocesses auto
 verbosity_test_cases=2
+
+[coverage:run]
+# Create separate coverage data files for each parallel worker
+parallel = true
+concurrency = multiprocessing

shiny/types.py

@@ -44,18 +44,20 @@ class MISSING_TYPE:
     pass
 
 
-MISSING: MISSING_TYPE = MISSING_TYPE()
-DEPRECATED: MISSING_TYPE = MISSING_TYPE()  # A MISSING that communicates deprecation
+MISSING: MISSING_TYPE = MISSING_TYPE()  # pragma: no cover
+DEPRECATED: MISSING_TYPE = (
+    MISSING_TYPE()
+)  # A MISSING that communicates deprecation  # pragma: no cover
 
-ListOrTuple = Union[List[T], Tuple[T, ...]]
+ListOrTuple = Union[List[T], Tuple[T, ...]]  # pragma: no cover
 
 
 # Information about a single file, with a structure like:
 #   {'name': 'mtcars.csv', 'size': 1303, 'type': 'text/csv', 'datapath: '/...../mtcars.csv'}
 # The incoming data doesn't include 'datapath'; that field is added by the
 # FileUploadOperation class.
-@add_example(ex_dir="./api-examples/input_file")
-class FileInfo(TypedDict):
+@add_example(ex_dir="./api-examples/input_file")  # pragma: no cover
+class FileInfo(TypedDict):  # pragma: no cover
     """
     Class for information about a file upload.
 
@@ -74,8 +76,8 @@ class FileInfo(TypedDict):
     """The path to the file on the server."""
 
 
-@add_example(ex_dir="./api-examples/output_image")
-class ImgData(TypedDict):
+@add_example(ex_dir="./api-examples/output_image")  # pragma: no cover
+class ImgData(TypedDict):  # pragma: no cover
     """
     Return type for :class:`~shiny.render.image`.
 
@@ -185,8 +187,8 @@ def __init__(self, message: str, sanitize: bool = True, close: bool = False):
         self.close = close
 
 
-class ActionButtonValue(int):
-    pass
+class ActionButtonValue(int):  # pragma: no cover
+    pass  # pragma: no cover
 
 
 class NavSetArg(Protocol):

tests/pytest/test_accordion.py

@@ -0,0 +1,100 @@
+"""Tests for accordion UI components."""
+
+from shiny.ui import (
+    accordion,
+    accordion_panel,
+)
+
+
+class TestAccordionPanel:
+    """Tests for accordion_panel function."""
+
+    def test_basic_accordion_panel(self):
+        """Test creating a basic accordion panel."""
+        panel = accordion_panel("Panel Title", "Panel content")
+        assert panel is not None
+        assert panel._data_value == "Panel Title"
+
+    def test_accordion_panel_with_value(self):
+        """Test accordion panel with explicit value."""
+        panel = accordion_panel("Display Title", "Content", value="panel_id")
+        assert panel._data_value == "panel_id"
+
+    def test_accordion_panel_with_icon(self):
+        """Test accordion panel with icon."""
+        from htmltools import tags
+
+        icon = tags.i(class_="fa fa-cog")
+        panel = accordion_panel("Settings", "Settings content", icon=icon)
+        assert panel is not None
+        assert panel._icon is not None
+
+
+class TestAccordion:
+    """Tests for accordion function."""
+
+    def test_basic_accordion(self):
+        """Test creating a basic accordion."""
+        acc = accordion(
+            accordion_panel("Panel 1", "Content 1"),
+            accordion_panel("Panel 2", "Content 2"),
+        )
+        html = str(acc)
+
+        assert "accordion" in html
+        assert "Panel 1" in html
+        assert "Panel 2" in html
+
+    def test_accordion_with_id(self):
+        """Test accordion with id."""
+        acc = accordion(accordion_panel("Panel 1", "Content 1"), id="my_accordion")
+        html = str(acc)
+
+        assert "my_accordion" in html
+
+    def test_accordion_open_panels(self):
+        """Test accordion with specific panels open."""
+        acc = accordion(
+            accordion_panel("Panel 1", "Content 1"),
+            accordion_panel("Panel 2", "Content 2"),
+            open="Panel 1",
+        )
+        html = str(acc)
+
+        assert "Panel 1" in html
+
+    def test_accordion_open_all(self):
+        """Test accordion with all panels open."""
+        acc = accordion(
+            accordion_panel("Panel 1", "Content 1"),
+            accordion_panel("Panel 2", "Content 2"),
+            open=True,
+        )
+        html = str(acc)
+
+        assert "Panel 1" in html
+
+    def test_accordion_multiple(self):
+        """Test accordion that allows multiple panels open."""
+        acc = accordion(
+            accordion_panel("Panel 1", "Content 1"),
+            accordion_panel("Panel 2", "Content 2"),
+            multiple=True,
+        )
+        html = str(acc)
+
+        assert "accordion" in html
+
+    def test_accordion_width(self):
+        """Test accordion with explicit width."""
+        acc = accordion(accordion_panel("Panel 1", "Content 1"), width="400px")
+        html = str(acc)
+
+        assert "400px" in html
+
+    def test_accordion_height(self):
+        """Test accordion with explicit height."""
+        acc = accordion(accordion_panel("Panel 1", "Content 1"), height="300px")
+        html = str(acc)
+
+        assert "300px" in html

tests/pytest/test_accordion_full.py

@@ -0,0 +1,80 @@
+"""Tests for shiny/ui/_accordion.py module."""
+
+from shiny.ui._accordion import AccordionPanel, accordion, accordion_panel
+
+
+class TestAccordion:
+    """Tests for accordion function."""
+
+    def test_accordion_is_callable(self):
+        """Test accordion is callable."""
+        assert callable(accordion)
+
+    def test_accordion_returns_tag(self):
+        """Test accordion returns a Tag."""
+        from htmltools import Tag
+
+        result = accordion(
+            accordion_panel("Panel 1", "Content 1"),
+            accordion_panel("Panel 2", "Content 2"),
+        )
+        assert isinstance(result, Tag)
+
+    def test_accordion_with_id(self):
+        """Test accordion with id parameter."""
+        from htmltools import Tag
+
+        result = accordion(
+            accordion_panel("Panel 1", "Content 1"),
+            id="my_accordion",
+        )
+        assert isinstance(result, Tag)
+
+
+class TestAccordionPanel:
+    """Tests for accordion_panel function."""
+
+    def test_accordion_panel_is_callable(self):
+        """Test accordion_panel is callable."""
+        assert callable(accordion_panel)
+
+    def test_accordion_panel_returns_accordion_panel(self):
+        """Test accordion_panel returns an AccordionPanel object."""
+        result = accordion_panel("Panel Title", "Content")
+        assert isinstance(result, AccordionPanel)
+
+
+class TestAccordionPanelClass:
+    """Tests for AccordionPanel class."""
+
+    def test_accordion_panel_class_exists(self):
+        """Test AccordionPanel class exists."""
+        assert AccordionPanel is not None
+
+
+class TestAccordionExported:
+    """Tests for accordion functions export."""
+
+    def test_accordion_in_ui(self):
+        """Test accordion is in ui module."""
+        from shiny import ui
+
+        assert hasattr(ui, "accordion")
+
+    def test_accordion_panel_in_ui(self):
+        """Test accordion_panel is in ui module."""
+        from shiny import ui
+
+        assert hasattr(ui, "accordion_panel")
+
+    def test_update_accordion_in_ui(self):
+        """Test update_accordion is in ui module."""
+        from shiny import ui
+
+        assert hasattr(ui, "update_accordion")
+
+    def test_update_accordion_panel_in_ui(self):
+        """Test update_accordion_panel is in ui module."""
+        from shiny import ui
+
+        assert hasattr(ui, "update_accordion_panel")