Add lookup strategy to writer #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddeboer
force-pushed
the
lookup-strategy
branch
from
bb7e615
to
cb38897
Compare
|
Wow you'r fast 😲 Good Job! |
Baachi
approved these changes
Dec 8, 2017
|
Should we add a depreciation note somewhere? So we can remove this static constructur in the next major version? |
They are silenced, following the Symfony way: https://symfony.com/doc/current/components/phpunit_bridge.html#trigger-deprecation-notices
|
Added a (silenced) deprecation warning. |
ddeboer
commented
Dec 8, 2017
| * @param string $lookupMethod Method used for looking up the item | ||
| * @param LookupStrategy $lookupStrategy | ||
| * | ||
| * @throws UnsupportedDatabaseTypeException | ||
| */ | ||
| public function __construct( | ||
| ObjectManager $objectManager, | ||
| $objectName, |
There was a problem hiding this comment.
$objectName needs to passed both here and when constructing a LookupStrategy. Not very elegant, but I don’t see any other options now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #9 (comment).
Fix #3: if you want to use QueryBuilder, you can just implement your own
LookupStrategy.