Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor icon refresh #2470

Closed
wants to merge 0 commits into from
Closed

Minor icon refresh #2470

wants to merge 0 commits into from

Conversation

sabbrad6
Copy link

@sabbrad6 sabbrad6 commented Jan 7, 2025

Dont merge until i remove draft

New pr at #2473

@sabbrad6 sabbrad6 marked this pull request as draft January 7, 2025 10:46
@gullradriel
Copy link
Member

Don't worry. I'm not going to merge it since there are already a few problems:

  • instead of applying black background, you should enforce transparent one / test that it's working with transparent instead of black background
  • size of new icon do not look good may render bad in the UI (24x24 instead of 16x16)

@zxkmm
Copy link
Contributor

zxkmm commented Jan 7, 2025

And also, before you put too many works on it, you probably should discuss with the community about the change. Cuz it would be sad that you put many work but community don't like it, in that case we have to close it at the end.

You can start a vote on discord or something.

@sabbrad6
Copy link
Author

sabbrad6 commented Jan 8, 2025

Don't worry. I'm not going to merge it since there are already a few problems:

  • instead of applying black background, you should enforce transparent one / test that it's working with transparent instead of black background
  • size of new icon do not look good may render bad in the UI (24x24 instead of 16x16)

Thanks for the feedback im going to improve it

@sabbrad6
Copy link
Author

sabbrad6 commented Jan 8, 2025

Ima start a new pr with right icon sizes
]

@eried
Copy link
Member

eried commented Jan 8, 2025

Where are the new icons? 🤓

@sabbrad6
Copy link
Author

sabbrad6 commented Jan 8, 2025

Where are the new icons? 🤓
Ima start a new pr with right icon sizes

@sabbrad6
Copy link
Author

sabbrad6 commented Jan 8, 2025

New pr here #2473

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants