Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLE RX: fix for empty text prompt crash #2468

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

gullradriel
Copy link
Member

This is a PR to fix #2462

Problem was that putting empty text in text_prompt for save entry or list filename was first changing the theme by writing bad things in memory, and a second call with the same empty behavior was crashing the app.

I didn't find any nice and clever way to do it. I did it my way.

At least that patch is solving the issue and displaying correct error messages.

imageimage

(There are two other error message that can be triggered, but I didn't took screenshot of them)

PS: if one is asking himself why I didn't use class functions and all instead of the static variable, it's because BLE RX is using 3 differents classes and when I tried it was crashing because of navigation mayhem (nav pop was not clearing correctly, crashing, etc)

Copy link
Member

@htotoo htotoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Later we may need to get another solution for the "if" in the "on_timer()", but good for now, as it works as intended.

@gullradriel gullradriel merged commit 0124051 into portapack-mayhem:next Jan 7, 2025
3 checks passed
@gullradriel gullradriel deleted the ble_rx_fix branch January 9, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Theme getting cyan with BLE RX application. Easter Egg? Bug?
2 participants