BLE RX: fix for empty text prompt crash #2468
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to fix #2462
Problem was that putting empty text in text_prompt for save entry or list filename was first changing the theme by writing bad things in memory, and a second call with the same empty behavior was crashing the app.
I didn't find any nice and clever way to do it. I did it my way.
At least that patch is solving the issue and displaying correct error messages.
(There are two other error message that can be triggered, but I didn't took screenshot of them)
PS: if one is asking himself why I didn't use class functions and all instead of the static variable, it's because BLE RX is using 3 differents classes and when I tried it was crashing because of navigation mayhem (nav pop was not clearing correctly, crashing, etc)