Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app manager #2442

Merged
merged 18 commits into from
Dec 27, 2024
Merged

app manager #2442

merged 18 commits into from
Dec 27, 2024

Conversation

zxkmm
Copy link
Contributor

@zxkmm zxkmm commented Dec 24, 2024

feat

things to decide

  • should this one ext app or inner app?
  • should remove auto start section in setting or not

notes

  • only save a index and calculate every time is because use struct vec would eat all ram
  • ext apps and inner apps has some differences, so some place have to overload or have a chooser in lambda
  • some workaround needed to save ram, which cause the menu a bit lagging when highlighted external apps (only a bit lagging, not freeze or crash), that's the best i can do due to ram limitations.

@zxkmm zxkmm marked this pull request as ready for review December 24, 2024 15:49
@gullradriel
Copy link
Member

Why is it making the main menu more lagging ?

@gullradriel
Copy link
Member

should this one ext app or inner app?

You already made it external. Is there any benefit to have it internal ?

How is autostart working ? Pmem value or sdcard file ? If it can work without a sdcard, it should be internal.

If both are working with an sdcard file, or if you prefer to leave it external, then external it will be. I don't think blacklist will work without a sdcard anyway.

should remove auto start section in setting or not

If we merge your app, and once we resolve everything I think we will, then yes, also commit the removal. No need to have two apps doing the same thing (I see you, Scanner app X-D ).

@zxkmm
Copy link
Contributor Author

zxkmm commented Dec 26, 2024

Why is it making the main menu more lagging ?

really? I didn’t saw differences, would you mind take a video?

@gullradriel
Copy link
Member

gullradriel commented Dec 26, 2024

really? I didn’t saw differences, would you mind take a video?

I misread. It was in your notes:

some workaround needed to save ram, which cause the menu a bit lagging when highlighted external apps (only a bit lagging, not freeze or crash), that's the best i can do due to ram limitations.

@zxkmm
Copy link
Contributor Author

zxkmm commented Dec 27, 2024

Ohhhh sorry, I meant it's the menu itself (not main menu) is lagging.

How is autostart working ? Pmem value or sdcard file ? If it can work without a sdcard, it should be internal.

Both of them won't work without sdcard. But both can work without correctly put sdcard content. (E.g. empty sdcard)

Also good night!

@gullradriel
Copy link
Member

Then when you have time please commit the autostart app removal in that PR, and let's merge :-)

@gullradriel
Copy link
Member

See you tomorrow ^^

zxkmm and others added 6 commits December 27, 2024 10:26
* fix wrong cast

* sorry, forgot to use enum
* enabled exFAT in ffconf
* added exFAT to sd card check
* solved todo
Actually valid complete ali h4m link
@zxkmm zxkmm marked this pull request as draft December 27, 2024 02:33
Merge branch 'next' into app_man
@zxkmm zxkmm marked this pull request as ready for review December 27, 2024 09:01
Copy link
Member

@gullradriel gullradriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@gullradriel gullradriel merged commit af36260 into portapack-mayhem:next Dec 27, 2024
3 checks passed
@zxkmm zxkmm deleted the app_man branch December 27, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"blacklist" file editor
5 participants