Merge pull request kubevirt#560 from fabiand/noNodeSelectorsAndSepara…

…teServices

No node selectors and separate services

automation/test.sh

@@ -124,7 +124,14 @@ while [ "$(kubectl get pods -o'custom-columns=status:status.containerStatuses[*]
     sleep 10
 done
 
-kubectl get pods
+# Wait until all pods are running
+while [ -n "$(kubectl get pods --no-headers --all-namespaces | grep -v Running)" ]; do
+    echo "Waiting for pods in all namespaces to enter the Running state ..."
+    kubectl get pods --no-headers --all-namespaces | >&2 grep -v Running || true
+    sleep 5
+done
+
+kubectl get pods --all-namespaces
 kubectl version
 
 # Disable proxy configuration since it causes test issues

cluster/deploy.sh

@@ -21,6 +21,32 @@ set -ex
 
 KUBECTL=${KUBECTL:-kubectl}
 
+externalServiceManifests()
+{
+  source hack/config.sh
+
+  # Pretty much equivalent to `kubectl expose service ...`
+  for SVC in spice-proxy:3128 virt-api:8182 haproxy:8184 virt-manifest:8186;
+  do
+    IFS=: read NAME PORT <<<$SVC
+    cat <<EOF
+apiVersion: v1
+kind: Service
+metadata:
+  name: external-$NAME
+spec:
+  externalIPs:
+  - "$master_ip"
+  ports:
+    - port: $PORT
+      targetPort: $PORT
+  selector:
+    app: $NAME
+---
+EOF
+  done
+}
+
 echo "Cleaning up ..."
 # Work around https://github.com/kubernetes/kubernetes/issues/33517
 cluster/kubectl.sh --core delete -f manifests/virt-handler.yaml --cascade=false --grace-period 0 2>/dev/null || :
@@ -35,6 +61,9 @@ cluster/kubectl.sh --core delete thirdpartyresources --all  || :
 # Make sure that the vms CRD is deleted, we use virtualmachines now
 cluster/kubectl.sh --core delete customresourcedefinitions vms.kubevirt.io  || :
 
+# Remove all external facing services
+externalServiceManifests | cluster/kubectl.sh --core delete -f - || :
+
 # Delete everything else
 for i in `ls manifests/*.yaml`; do
     $KUBECTL delete -f $i --grace-period 0 2>/dev/null || :
@@ -43,6 +72,8 @@ done
 sleep 2
 
 echo "Deploying ..."
+externalServiceManifests | cluster/kubectl.sh --core apply -f -
+
 for i in `ls manifests/*.yaml`; do
     $KUBECTL create -f $i
 done

images/haproxy/haproxy.cfg

@@ -25,7 +25,7 @@ backend srvs_kubevirt
    timeout connect 10s
    timeout server 1m
    balance roundrobin
-   server host1 virt-api-service:8183 resolvers kubernetes
+   server host1 virt-api:8183 resolvers kubernetes
 
 backend srvs_apiserver
    mode http

manifests/haproxy.yaml.in

@@ -1,13 +1,11 @@
 apiVersion: v1
 kind: Service
 metadata:
-  name: haproxy-service
+  name: haproxy
 spec:
   ports:
     - port: 8184
       targetPort: haproxy
-  externalIPs :
-    - "{{ master_ip }}"
   selector:
     app: haproxy
 ---
@@ -44,5 +42,3 @@ spec:
           periodSeconds: 20
       securityContext:
         runAsNonRoot: true
-      nodeSelector:
-        kubernetes.io/hostname: {{ primary_node_name }}

manifests/iscsi-auth-demo-target.yaml.in

@@ -50,5 +50,3 @@ spec:
         - name: host
           hostPath:
             path: /
-      nodeSelector:
-        kubernetes.io/hostname: {{ primary_node_name }}

manifests/iscsi-demo-target.yaml.in

@@ -133,5 +133,3 @@ spec:
         - name: host
           hostPath:
             path: /
-      nodeSelector:
-        kubernetes.io/hostname: {{ primary_node_name }}

manifests/squid.yaml.in

@@ -6,8 +6,6 @@ spec:
   ports:
     - port: 3128
       targetPort: spice-proxy
-  externalIPs:
-    - "{{ master_ip }}"
   selector:
     app: spice-proxy
 ---
@@ -31,5 +29,3 @@ spec:
               protocol: "TCP"
       securityContext:
         runAsNonRoot: true
-      nodeSelector:
-        kubernetes.io/hostname: {{ primary_node_name }}

manifests/virt-api.yaml.in

@@ -1,13 +1,11 @@
 apiVersion: v1
 kind: Service
 metadata:
-  name: virt-api-service
+  name: virt-api
 spec:
   ports:
     - port: 8183
       targetPort: virt-api
-  externalIPs :
-    - "{{ master_ip }}"
   selector:
     app: virt-api
 ---
@@ -38,5 +36,3 @@ spec:
             protocol: "TCP"
       securityContext:
         runAsNonRoot: true
-      nodeSelector:
-        kubernetes.io/hostname: {{ primary_node_name }}

manifests/virt-controller.yaml.in

@@ -1,13 +1,11 @@
 apiVersion: v1
 kind: Service
 metadata:
-  name: virt-controller-service
+  name: virt-controller
 spec:
   ports:
     - port: 8182
       targetPort: virt-controller
-  externalIPs:
-    - "{{ master_ip }}"
   selector:
     app: virt-controller
 ---
@@ -54,5 +52,3 @@ spec:
           timeoutSeconds: 10
       securityContext:
         runAsNonRoot: true
-      nodeSelector:
-        kubernetes.io/hostname: {{ primary_node_name }}

manifests/virt-manifest.yaml.in

@@ -1,13 +1,11 @@
 apiVersion: v1
 kind: Service
 metadata:
-  name: virt-manifest-service
+  name: virt-manifest
 spec:
   ports:
     - port: 8186
       targetPort: virt-manifest
-  externalIPs:
-    - "{{ master_ip }}"
   selector:
     app: virt-manifest
 ---
@@ -64,5 +62,3 @@ spec:
       volumes:
       - name: libvirt-runtime
         emptyDir: {}
-      nodeSelector:
-        kubernetes.io/hostname: {{ primary_node_name }}

pkg/virt-controller/leaderelectionconfig/config.go

@@ -32,7 +32,7 @@ const (
 	DefaultRenewDeadline = 10 * time.Second
 	DefaultRetryPeriod   = 2 * time.Second
 	DefaultNamespace     = "default"
-	DefaultEndpointName  = "virt-controller-service"
+	DefaultEndpointName  = "virt-controller"
 )
 
 func DefaultLeaderElectionConfiguration() Configuration {

tests/registry_disk_test.go

@@ -85,7 +85,7 @@ var _ = Describe("RegistryDisk", func() {
 			for i := 0; i < num; i++ {
 				obj, err := virtClient.RestClient().Post().Resource("virtualmachines").Namespace(tests.NamespaceTestDefault).Body(vm).Do().Get()
 				Expect(err).To(BeNil())
-				tests.WaitForSuccessfulVMStartWithTimeout(obj, 120)
+				tests.WaitForSuccessfulVMStartWithTimeout(obj, 180)
 				_, err = virtClient.RestClient().Delete().Resource("virtualmachines").Namespace(vm.GetObjectMeta().GetNamespace()).Name(vm.GetObjectMeta().GetName()).Do().Get()
 				Expect(err).To(BeNil())
 				tests.NewObjectEventWatcher(obj).SinceWatchedObjectResourceVersion().WaitFor(tests.NormalEvent, v1.Deleted)

tests/replicaset_test.go

@@ -105,7 +105,7 @@ var _ = Describe("VirtualMachineReplicaSet", func() {
 				rs, err := virtClient.ReplicaSet(tests.NamespaceTestDefault).Get(newRS.ObjectMeta.Name, v12.GetOptions{})
 				Expect(err).ToNot(HaveOccurred())
 				return int(rs.Status.ReadyReplicas)
-			}, 60*time.Second, 1*time.Second).Should(Equal(2))
+			}, 120*time.Second, 1*time.Second).Should(Equal(2))
 		})
 
 		It("should not scale when paused and scale when resume", func() {

tests/utils.go

@@ -752,7 +752,7 @@ func WaitForSuccessfulVMStartWithTimeout(vm runtime.Object, seconds int) (nodeNa
 }
 
 func WaitForSuccessfulVMStart(vm runtime.Object) string {
-	return WaitForSuccessfulVMStartWithTimeout(vm, 5)
+	return WaitForSuccessfulVMStartWithTimeout(vm, 30)
 }
 
 func GetReadyNodes() []k8sv1.Node {

tests/vm_migration_test.go

@@ -45,7 +45,7 @@ var _ = Describe("VmMigration", func() {
 
 	var sourceVM *v1.VirtualMachine
 
-	var TIMEOUT float64 = 10.0
+	var TIMEOUT float64 = 60.0
 	var POLLING_INTERVAL float64 = 0.1
 
 	BeforeEach(func() {